JRuby

Zlib::GzipReader should wrap the GZIPInputStream in a BufferedInputStream for performance

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Fixed
  • Affects Version/s: JRuby 1.4
  • Fix Version/s: JRuby 1.5
  • Component/s: Extensions
  • Labels:
    None
  • Number of attachments :
    0

Description

java.util.zip.GZIPInputStream is not internally buffered, so every call to read results in a JNI call to decompress a small amount of data.

By simply wrapping the GZIPInputStream in a BufferedInputStream, the inflater overhead is reduced significantly.

Activity

Ascending order - Click to sort in descending order
Thomas E Enebo made changes -
Field Original Value New Value
Component/s Extensions [ 12281 ]
Description
java.util.zip.GZIPInputStream is not internally buffered, so every call to read results in a JNI call to decompress a small amount of data.

By simply wrapping the GZIPInputStream in a BufferedInputStream, the inflater overhead is reduced significantly.

 java.util.zip.GZIPInputStream is not internally buffered, so every call to read results in a JNI call to decompress a small amount of data.

By simply wrapping the GZIPInputStream in a BufferedInputStream, the inflater overhead is reduced significantly.
Hide
Permalink
Ola Bini added a comment -

This seems to have already been done.

Show
Ola Bini added a comment - This seems to have already been done.
Ola Bini made changes -
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
Hide
Permalink
Hiroshi Nakamura added a comment -

I posted a patch for JRUBY-4503 which includes this change (committed at http://github.com/jruby/jruby/commit/d5794fe3783dc10e6c7d1b0dabf9e93b483ea5ff) It's totally an unintentional fix... I was not aware this ticket.

The change is required for chunked read test to let the buffer in Inflater work. But as the reporter said, it should be included for reducing buffering overhead.

Show
Hiroshi Nakamura added a comment - I posted a patch for JRUBY-4503 which includes this change (committed at http://github.com/jruby/jruby/commit/d5794fe3783dc10e6c7d1b0dabf9e93b483ea5ff ) It's totally an unintentional fix... I was not aware this ticket. The change is required for chunked read test to let the buffer in Inflater work. But as the reporter said, it should be included for reducing buffering overhead.
Charles Oliver Nutter made changes -
Status Resolved [ 5 ] Closed [ 6 ]

People

  • Assignee:
    Wayne Meissner
    Reporter:
    Wayne Meissner
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: