JRuby

[1.9] prelude.rb causes the load of ThreadLibrary by default

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: JRuby 1.4.0RC2
  • Fix Version/s: None
  • Component/s: Intro, Ruby 1.9.2
  • Labels:
    None
  • Number of attachments :
    0

Description

We have weird prelude.rb content, with require "thread.jar" in there, which causes thread library to be loaded by default in 1.9 mode.

It doesn't make sense. We load Thread library and then redefine some ThreadLibrary's behavior. Why loading of thread library needed at all? MRI 1.9 version of prelude.rb doesn't load 'thread'.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Thomas E Enebo added a comment -

Interestingly there is a subset of Thread,ThreadGroup, and Mutex which are loaded by default with the rest getting loaded by thread.rb. So our thread.rb will load thread.jar and we just need to make sure the appropriate methods are loaded in initCore by default.

For any hackers interested on a JRuby project this is pretty simple. Just add 1.9 method annotated versions for all methods defined in Ruby 1.9s thread.c and then nuke our require 'thread.jar' from prelude.rb.

Show
Thomas E Enebo added a comment - Interestingly there is a subset of Thread,ThreadGroup, and Mutex which are loaded by default with the rest getting loaded by thread.rb. So our thread.rb will load thread.jar and we just need to make sure the appropriate methods are loaded in initCore by default. For any hackers interested on a JRuby project this is pretty simple. Just add 1.9 method annotated versions for all methods defined in Ruby 1.9s thread.c and then nuke our require 'thread.jar' from prelude.rb.
Hide
Permalink
Charles Oliver Nutter added a comment -

This has played out over time and we're fine as-is. MRI does not explicitly load the 'thread' library, but it does present all thread library features from boot. Our load of the library is acceptable.

Show
Charles Oliver Nutter added a comment - This has played out over time and we're fine as-is. MRI does not explicitly load the 'thread' library, but it does present all thread library features from boot. Our load of the library is acceptable.

People

  • Assignee:
    Charles Oliver Nutter
    Reporter:
    Vladimir Sizikov
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: