Mangled Joda-Time package breaks public APIs that return or consume Joda-Time objects

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: JRuby 1.4.0RC1
  • Fix Version/s: JRuby 1.4
  • Component/s: Core Classes/Modules
  • Labels:
    None

Description

Some APIs on RubyTime return or receive Joda-Time DateTime objects. Since we mangle the Joda package, however, we break any consumers of those APIs that don't similarly mangle their APIs. So I believe we need to revert the mangling and recommend users deal with conflicts in other ways.

We should also update to latest Joda-Time, to ensure we're at least current for 1.4 release.

See this thread for more information: http://groups.google.com/group/jruby-users/browse_thread/thread/fb1d3274d5251d8f

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Thomas E Enebo added a comment -

Fixed in master at 67ff510. Fixed in 1.4 branch in 42a1d6f.

Show
Thomas E Enebo added a comment - Fixed in master at 67ff510. Fixed in 1.4 branch in 42a1d6f.
Hide
Permalink
Nick Sieger added a comment -

This has been fixed for a while but I thought I'd mention the opposite side of this issue, where not changing the class names causes conflicts with containers that use different versions of joda.

Maybe it would be possible to obscure our use of joda as only a private library, and not let the objects leak out?

https://github.com/nicksieger/jruby-rack/issues/24

Show
Nick Sieger added a comment - This has been fixed for a while but I thought I'd mention the opposite side of this issue, where not changing the class names causes conflicts with containers that use different versions of joda. Maybe it would be possible to obscure our use of joda as only a private library, and not let the objects leak out? https://github.com/nicksieger/jruby-rack/issues/24
Hide
Permalink
Nick Sieger added a comment -

OTOH, maybe this conflict is such an obscure case that we shouldn't worry about it...

Show
Nick Sieger added a comment - OTOH, maybe this conflict is such an obscure case that we shouldn't worry about it...
Hide
Permalink
kristian meier added a comment -

this issue-24 is not really a jruby problem, any 3rd party library which needs a newer version of joda-time will face the same problem with weblogic. to reverse the class resolution of the web-container is a way to solve it - as done by the reporters on that issue-24.

Show
kristian meier added a comment - this issue-24 is not really a jruby problem, any 3rd party library which needs a newer version of joda-time will face the same problem with weblogic. to reverse the class resolution of the web-container is a way to solve it - as done by the reporters on that issue-24.

People

  • Assignee:
    Thomas E Enebo
    Reporter:
    Charles Oliver Nutter
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: