JRuby

ActiveSupport::Multibyte utils test failures

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Incomplete
  • Affects Version/s: JRuby 1.3.1
  • Fix Version/s: None
  • Component/s: HelpWanted
  • Labels:
    None
  • Number of attachments :
    0

Description

We ran activesupport cleanly at some point, but we have a couple of new test failures due to the recent UTF-8 XSS vulnerability issue. They look like kcode issues.

  1) Failure:
test_clean_cleans_invalid_characters_from_UTF-8_encoded_strings(MultibyteUtilsTest)
    [./test/multibyte_utils_test.rb:73:in `test_clean_cleans_invalid_characters_from_UTF-8_encoded_strings'
     /Users/nicksieger/Projects/ruby/rails/activesupport/test/abstract_unit.rb:22:in `with_kcode'
     ./test/multibyte_utils_test.rb:71:in `test_clean_cleans_invalid_characters_from_UTF-8_encoded_strings'
     /Users/nicksieger/Projects/ruby/rails/activesupport/test/../lib/active_support/testing/setup_and_teardown.rb:62:in `run']:
<"&#12371;&#12395;&#12385;&#12431;"> expected but was
<"">.

  2) Failure:
test_verify_verifies_Shift-JIS_strings_are_properly_encoded(MultibyteUtilsTest)
    [./test/multibyte_utils_test.rb:38:in `test_verify_verifies_Shift-JIS_strings_are_properly_encoded'
     /Users/nicksieger/Projects/ruby/rails/activesupport/test/abstract_unit.rb:22:in `with_kcode'
     ./test/multibyte_utils_test.rb:37:in `test_verify_verifies_Shift-JIS_strings_are_properly_encoded'
     /Users/nicksieger/Projects/ruby/rails/activesupport/test/../lib/active_support/testing/setup_and_teardown.rb:62:in `run']:

Activity

No work has yet been logged on this issue.

People

  • Assignee:
    Thomas E Enebo
    Reporter:
    Nick Sieger
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: