JRuby

ActiveSupport::Multibyte utils test failures

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Incomplete
  • Affects Version/s: JRuby 1.3.1
  • Fix Version/s: None
  • Component/s: HelpWanted
  • Labels:
    None
  • Number of attachments :
    0

Description

We ran activesupport cleanly at some point, but we have a couple of new test failures due to the recent UTF-8 XSS vulnerability issue. They look like kcode issues.

  1) Failure:
test_clean_cleans_invalid_characters_from_UTF-8_encoded_strings(MultibyteUtilsTest)
    [./test/multibyte_utils_test.rb:73:in `test_clean_cleans_invalid_characters_from_UTF-8_encoded_strings'
     /Users/nicksieger/Projects/ruby/rails/activesupport/test/abstract_unit.rb:22:in `with_kcode'
     ./test/multibyte_utils_test.rb:71:in `test_clean_cleans_invalid_characters_from_UTF-8_encoded_strings'
     /Users/nicksieger/Projects/ruby/rails/activesupport/test/../lib/active_support/testing/setup_and_teardown.rb:62:in `run']:
<"&#12371;&#12395;&#12385;&#12431;"> expected but was
<"">.

  2) Failure:
test_verify_verifies_Shift-JIS_strings_are_properly_encoded(MultibyteUtilsTest)
    [./test/multibyte_utils_test.rb:38:in `test_verify_verifies_Shift-JIS_strings_are_properly_encoded'
     /Users/nicksieger/Projects/ruby/rails/activesupport/test/abstract_unit.rb:22:in `with_kcode'
     ./test/multibyte_utils_test.rb:37:in `test_verify_verifies_Shift-JIS_strings_are_properly_encoded'
     /Users/nicksieger/Projects/ruby/rails/activesupport/test/../lib/active_support/testing/setup_and_teardown.rb:62:in `run']:

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Diego Plentz added a comment -

Just tried to run activesupport tests from rails master and got this error:

~/Projects/opensource/rails/activesupport (master) $ bundle exec rake
/Users/plentz/.rvm/rubies/jruby-1.6.7/bin/jruby -w -I"lib:test" -I"/Users/plentz/.rvm/gems/jruby-1.6.7/gems/rake-0.9.2.2/lib" "/Users/plentz/.rvm/gems/jruby-1.6.7/gems/rake-0.9.2.2/lib/rake/rake_test_loader.rb" "test/**/*_test.rb" 
NoMethodError: undefined method `register_spec_type' for ActiveSupport::TestCase:Class
       TestCase at /Users/plentz/Projects/opensource/rails/activesupport/lib/active_support/test_case.rb:20
  ActiveSupport at /Users/plentz/Projects/opensource/rails/activesupport/lib/active_support/test_case.rb:11
         (root) at /Users/plentz/Projects/opensource/rails/activesupport/lib/active_support/test_case.rb:10
         (root) at /Users/plentz/Projects/opensource/rails/activesupport/lib/active_support/test_case.rb:3
        require at org/jruby/RubyKernel.java:1042
       __file__ at /Users/plentz/.rvm/gems/jruby-1.6.7/gems/rake-0.9.2.2/lib/rake/rake_test_loader.rb:10
           each at org/jruby/RubyArray.java:1615
       __file__ at /Users/plentz/.rvm/gems/jruby-1.6.7/gems/rake-0.9.2.2/lib/rake/rake_test_loader.rb:9
         select at org/jruby/RubyArray.java:2395
         (root) at /Users/plentz/.rvm/gems/jruby-1.6.7/gems/rake-0.9.2.2/lib/rake/rake_test_loader.rb:4
rake aborted!
Command failed with status (1): [/Users/plentz/.rvm/rubies/jruby-1.6.7/bin/...]

Tasks: TOP => default => test
(See full trace by running task with --trace)
Show
Diego Plentz added a comment - Just tried to run activesupport tests from rails master and got this error: ~/Projects/opensource/rails/activesupport (master) $ bundle exec rake /Users/plentz/.rvm/rubies/jruby-1.6.7/bin/jruby -w -I "lib:test" -I "/Users/plentz/.rvm/gems/jruby-1.6.7/gems/rake-0.9.2.2/lib" "/Users/plentz/.rvm/gems/jruby-1.6.7/gems/rake-0.9.2.2/lib/rake/rake_test_loader.rb" "test/**/*_test.rb" NoMethodError: undefined method `register_spec_type' for ActiveSupport::TestCase: Class TestCase at /Users/plentz/Projects/opensource/rails/activesupport/lib/active_support/test_case.rb:20 ActiveSupport at /Users/plentz/Projects/opensource/rails/activesupport/lib/active_support/test_case.rb:11 (root) at /Users/plentz/Projects/opensource/rails/activesupport/lib/active_support/test_case.rb:10 (root) at /Users/plentz/Projects/opensource/rails/activesupport/lib/active_support/test_case.rb:3 require at org/jruby/RubyKernel.java:1042 __file__ at /Users/plentz/.rvm/gems/jruby-1.6.7/gems/rake-0.9.2.2/lib/rake/rake_test_loader.rb:10 each at org/jruby/RubyArray.java:1615 __file__ at /Users/plentz/.rvm/gems/jruby-1.6.7/gems/rake-0.9.2.2/lib/rake/rake_test_loader.rb:9 select at org/jruby/RubyArray.java:2395 (root) at /Users/plentz/.rvm/gems/jruby-1.6.7/gems/rake-0.9.2.2/lib/rake/rake_test_loader.rb:4 rake aborted! Command failed with status (1): [/Users/plentz/.rvm/rubies/jruby-1.6.7/bin/...] Tasks: TOP => default => test (See full trace by running task with --trace)
Hide
Permalink
Thomas E Enebo added a comment -

No doubt we are still not green but we should make any errors individual reports so we can whittle this bug down bit by bit.

Show
Thomas E Enebo added a comment - No doubt we are still not green but we should make any errors individual reports so we can whittle this bug down bit by bit.

People

  • Assignee:
    Thomas E Enebo
    Reporter:
    Nick Sieger
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: