stringio and java libraries interact weirdly to create to_channel and other addons

Details

Description

I don't like that we are using the presence of StringIO to change the way Java integration installs to_channel/to_inputstream/to_outputstream for all Objects in the system. It should be formalized better and cleaned up.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Charles Oliver Nutter added a comment -

Along with fixing this we should add specs for the newly-restored IO#to_channel that returns the actual channel, and clean up how those IO-related to_* methods work for other IO-like objects. Perhaps the "any_to_*" methods in AnyIO should try to do to_io?

Show
Charles Oliver Nutter added a comment - Along with fixing this we should add specs for the newly-restored IO#to_channel that returns the actual channel, and clean up how those IO-related to_* methods work for other IO-like objects. Perhaps the "any_to_*" methods in AnyIO should try to do to_io?
Hide
Permalink
Aman Gupta added a comment -

violates POLS, for example:

$ jruby -rjava -rtempfile -e' p Tempfile.new("blah").to_channel '
: undefined method `to_channel' for #<File:/tmp/blah.19565.36699> (NoMethodError)

$ jruby -rstringio -rjava -rtempfile -e' p Tempfile.new("blah").to_channel '
#<Java::OrgJrubyUtil::IOChannel::IOReadableWritableByteChannel:0x1e1ec86 @java_object=#<Java::JavaObject:0x7dc21ece>>
Show
Aman Gupta added a comment - violates POLS, for example: 
$ jruby -rjava -rtempfile -e' p Tempfile.new("blah").to_channel '
: undefined method `to_channel' for #<File:/tmp/blah.19565.36699> (NoMethodError)

$ jruby -rstringio -rjava -rtempfile -e' p Tempfile.new("blah").to_channel '
#<Java::OrgJrubyUtil::IOChannel::IOReadableWritableByteChannel:0x1e1ec86 @java_object=#<Java::JavaObject:0x7dc21ece>>
Hide
Permalink
Thomas E Enebo added a comment -

Not making 1.4. HelpWanted

Show
Thomas E Enebo added a comment - Not making 1.4. HelpWanted

People

  • Assignee:
    Unassigned
    Reporter:
    Charles Oliver Nutter
Vote (1)
Watch (1)

Dates

  • Created:
    Updated: