JRuby (please use github issues at http://bugs.jruby.org)
  1. JRuby (please use github issues at http://bugs.jruby.org)
  2. JRUBY-3797

include_class should be deprecated in favor of java_import (and/or import)

    Details

    • Type: Improvement Improvement
    • Status: Resolved Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: JRuby 1.7.0.pre1
    • Component/s: Java Integration
    • Labels:
      None
    • Number of attachments :
      0

      Description

      We have too long had too many ways to import classes; we should eliminate at least include_class and probably settle on import and/or java_import as the blessed ways to pull in classes.

      We also do not want to publish include_class as a preferred or blessed way, and should make sure any remaining include_class-only features are in import/java_import.

        Activity

        Hide
        Charles Oliver Nutter added a comment -

        java_import is there and we have been recommending it, but we need to add a one-time warning to import and include_class that says they're deprecated or not recommended. Marking 1.x+.

        Show
        Charles Oliver Nutter added a comment - java_import is there and we have been recommending it, but we need to add a one-time warning to import and include_class that says they're deprecated or not recommended. Marking 1.x+.
        Hide
        Hiro Asari added a comment -

        Perhaps we can put the warning in for the 1.5 release.

        Show
        Hiro Asari added a comment - Perhaps we can put the warning in for the 1.5 release.
        Hide
        Hiro Asari added a comment -

        Replaced appropriate occurrences of include_class with java_import on the master (832dbef).

        We can consider removing it in JRuby 1.8.0.

        Show
        Hiro Asari added a comment - Replaced appropriate occurrences of include_class with java_import on the master (832dbef). We can consider removing it in JRuby 1.8.0.

          People

          • Assignee:
            Hiro Asari
            Reporter:
            Charles Oliver Nutter
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: