JRuby

Implement OpenSSL::X509::Request#to_pem

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: JRuby-OpenSSL 0.5
  • Fix Version/s: JRuby-OpenSSL 0.5.1
  • Component/s: OpenSSL
  • Labels:
    None
  • Environment:
    Mac OSX 10.5, jruby-openssl 0.5, jruby 1.3.0RC2 (ruby 1.8.6p287) (2009-05-21 3aadd8a) (Java HotSpot(TM) Client VM 1.5.0_16) [i386-java]
  • Testcase included:
    yes
  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Description

Still working on Puppet running with JRuby, this time it was lacking: OpenSSL::X509::Request#to_pem.

Please check the enclosed patch & ruby unit test, and apply if it meets your code requirements.

Activity

Hide
Charles Oliver Nutter added a comment -

This one didn't apply cleanly...but perhaps it just needs one or both of the previous patches Looking forward to getting them all in; apply issues aside, they look great!

Show
Charles Oliver Nutter added a comment - This one didn't apply cleanly...but perhaps it just needs one or both of the previous patches Looking forward to getting them all in; apply issues aside, they look great!
Hide
Brice Figureau added a comment -

Yes, you're right the patches are not independent and you need to apply first JRUBY-3689, JRUBY-3690, then this one.
If you want me to push everything in my github repository let me know.

Show
Brice Figureau added a comment - Yes, you're right the patches are not independent and you need to apply first JRUBY-3689, JRUBY-3690, then this one. If you want me to push everything in my github repository let me know.
Hide
Brice Figureau added a comment -

I pushed all the patches (ie JRUBY-3689, JRUBY-3690, JRUBY-3691, JRUBY-3694) I contributed this week-end to the puppet-fixes branch of my jruby-openssl fork in github:
http://github.com/masterzen/jruby-openssl/tree/puppet-fixes

This is rebased on top of 6a75b3, that will be easier to apply.

Show
Brice Figureau added a comment - I pushed all the patches (ie JRUBY-3689, JRUBY-3690, JRUBY-3691, JRUBY-3694) I contributed this week-end to the puppet-fixes branch of my jruby-openssl fork in github: http://github.com/masterzen/jruby-openssl/tree/puppet-fixes This is rebased on top of 6a75b3, that will be easier to apply.
Hide
Charles Oliver Nutter added a comment -

Applied via Github fork queue. Thanks!

Show
Charles Oliver Nutter added a comment - Applied via Github fork queue. Thanks!

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: