JRuby

OpenSSL::X509::CRL can't be created with PEM content

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: JRuby-OpenSSL 0.5
  • Fix Version/s: JRuby-OpenSSL 0.5.1
  • Component/s: OpenSSL
  • Labels:
    None
  • Environment:
    Mac OSX 10.5, jruby-openssl 0.5, jruby 1.3.0RC2 (ruby 1.8.6p287) (2009-05-21 3aadd8a) (Java HotSpot(TM) Client VM 1.5.0_16) [i386-java]
  • Testcase included:
    yes
  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Description

While (still) trying to run Puppet with JRuby, I discovered that it isn't possible to create an OpenSSL::X509::CRL object with PEM content read from disk. This capability is fundamental for Puppet to run (on a side note, Puppet is a good candidate for SSL works as it uses things in a different way than Net::HTTPS).

Please check the enclosed patch & ruby unit test, and apply if it meets your code requirements.

I didn't push the patch to my github repository, but it is possible if you want to merge directly.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Brice Figureau added a comment -

Oops, I created this ticket as a bug, it should be an "Improvement". It seems I don't have the power to make this change, though, so if a good will could do it that'd be really great.

Show
Brice Figureau added a comment - Oops, I created this ticket as a bug, it should be an "Improvement". It seems I don't have the power to make this change, though, so if a good will could do it that'd be really great.
Hide
Permalink
Charles Oliver Nutter added a comment -

Hmm, I tried to apply this patch, and it looked pretty good, but the test gives me:

  1) Failure:
test_create_from_pem(OpenSSL::TestX509CRL) [test/openssl/test_x509crl.rb:228]:
<2> expected but was
<1>.

Were you able to run this test successfully with your change?

BTW, thanks very much for the patches; OpenSSL has been a somewhat neglected area.

Show
Charles Oliver Nutter added a comment - Hmm, I tried to apply this patch, and it looked pretty good, but the test gives me: 
  1) Failure:
test_create_from_pem(OpenSSL::TestX509CRL) [test/openssl/test_x509crl.rb:228]:
<2> expected but was
<1>.
Were you able to run this test successfully with your change? BTW, thanks very much for the patches; OpenSSL has been a somewhat neglected area.
Hide
Permalink
Brice Figureau added a comment -

You're right the whole test was wrong (good catch )
Anyway, here is a working version.

Show
Brice Figureau added a comment - You're right the whole test was wrong (good catch ) Anyway, here is a working version.
Hide
Permalink
Charles Oliver Nutter added a comment -

Applied via Github fork queue. Thanks!

Show
Charles Oliver Nutter added a comment - Applied via Github fork queue. Thanks!

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.