JRuby

[19] Array#sort should honor modifications to String and Fixnum

Details

  • Number of attachments :
    0

Description

In Ruby 1.8, Array#sort had special-cased logic for Fixnum and String, and did not actually dispatch to their methods. In Ruby 1.9, it does dispatch if those methods have been overridden. We must honor this behavior.

Along with this we will need a fast way to check whether a method on a target class has been overridden, so we can quickly determine whether to try a full dispatch or not. This will have applicability to other bugs.

At any rate, getting the basic behavior in comes first.

Activity

Hide
Thomas E Enebo added a comment -

Not getting done for 1.4. HelpWanted.

Show
Thomas E Enebo added a comment - Not getting done for 1.4. HelpWanted.
Hide
Thomas E Enebo added a comment -

Fixed in commit 5799989.

Show
Thomas E Enebo added a comment - Fixed in commit 5799989.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: