JRuby

Array#pack needs modifications for 1.9 encoding support

Details

  • Number of attachments :
    0

Description

Most of the 1.9 support is done for Array, but we need to support encoding in Array#pack.

There should be tests under test/externals/ruby1.9/ruby for array that should updates to pack. Otherwise it may take a bit of code reading.

Activity

Hide
Thomas E Enebo added a comment -

Not going to make 1.4. HelpWanted

Show
Thomas E Enebo added a comment - Not going to make 1.4. HelpWanted
Hide
Martin Harriman added a comment -

Encoding appears to be supported in Array#pack; it passes the rubyspec tests (such as they are), and the logic in org/jruby/util/pack.rb looks very much like the logic in MRI. Is this actually fixed?

Show
Martin Harriman added a comment - Encoding appears to be supported in Array#pack; it passes the rubyspec tests (such as they are), and the logic in org/jruby/util/pack.rb looks very much like the logic in MRI. Is this actually fixed?
Hide
Charles Oliver Nutter added a comment -

One of my amorphous bugs. We'll close this as incomplete and defer to user reports, rubyspec tags, and MRI test failures.

Show
Charles Oliver Nutter added a comment - One of my amorphous bugs. We'll close this as incomplete and defer to user reports, rubyspec tags, and MRI test failures.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: