JRuby

popen breaks input channel for IRB

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: JRuby 1.1.6
  • Fix Version/s: JRuby 1.2
  • Component/s: Core Classes/Modules
  • Labels:
    None
  • Number of attachments :
    0

Description

This is pretty ugly. After doing an IO.popen("sleep 60") in IRB, the console becomes nearly unresponsive. Only a few characters get through, and only after pressing the key several times. I'm not sure what's going on, but 1.1.6 behaves the same way and we need to fix it for 1.2.

Activity

Hide
Permalink
Charles Oliver Nutter added a comment -

It looks like popen should not hook up the input of the subprocess to the input of the parent process, so this was a simple matter of closing the input of the subprocess and modifying other code to not try to access it. It passes all tests and specs, so here's hoping it's the right thing to do. I read through the MRI logic, and it's rather involved.

Show
Charles Oliver Nutter added a comment - It looks like popen should not hook up the input of the subprocess to the input of the parent process, so this was a simple matter of closing the input of the subprocess and modifying other code to not try to access it. It passes all tests and specs, so here's hoping it's the right thing to do. I read through the MRI logic, and it's rather involved.

People

  • Assignee:
    Charles Oliver Nutter
    Reporter:
    Charles Oliver Nutter
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: