RubySpec: new autoload failures in Kernel and Module

Charles Oliver Nutter added a comment - 12/Feb/09 3:03 AM Tagged in r9111.

Thomas E Enebo added a comment - 23/Feb/09 4:39 PM The defined? error has been fixed. The first failure is broken because of a failure by us to differentiate between calling a module and non-module version of the same method. If we call: Kernel.autoload :HEH, "some_file.rb" Then this should add it into whatever place it is being called from. We add it to Kernel. module Kernel autoload :HEH, "some_file.rb" end This example should in fact add it to Kernel (which we do, but we when we fix this we should make sure both of these work properly. Bumping to 1.x

John F. Douthat added a comment - 12/Sep/09 8:55 PM I believe the first issue is due to constant definitions in Kernel not showing up in Object, and isn't an issue with autoload. Check out the following failures # JRUBY FAILS (the basis of the spec, calling autoload on Kernel) Kernel.autoload :KSAutoloadBB, "no_autoload.rb" puts ( Object .constants.include?(:KSAutoloadBB) or Object .constants.include?('KSAutoloadBB')) # JRUBY FAILS (modification of the spec, calling autload from within Kernel) module Kernel autoload :KSAutoloadBB, "no_autoload.rb" end puts ( Object .constants.include?(:KSAutoloadBB) or Object .constants.include?('KSAutoloadBB')) # ALL PASS (autoload from within an arbitrary module) module Foo autoload :KSAutoloadBB, "no_autoload.rb" end puts (Foo.constants.include?(:KSAutoloadBB) or Foo.constants.include?('KSAutoloadBB')) # ALL PASS (autoload by calling autoload on an arbitrary module) module Foo end Foo.autoload :KSAutoloadBB, "no_autoload.rb" puts (Foo.constants.include?(:KSAutoloadBB) or Foo.constants.include?('KSAutoloadBB')) # JRUBY FAILS (defining a simple constant from within Kernel, which doesn't show up in Object in JRuby) module Kernel ASDF = 'hello' end puts ( Object .constants.include?(:ASDF) or Object .constants.include?('ASDF')) # JRUBY FAILS (defining a simple constant on Kernel, which doesn't show up in Object in JRuby) Kernel::ASDF = 'xzcv' puts ( Object .constants.include?(:ASDF) or Object .constants.include?('ASDF'))

John F. Douthat added a comment - 12/Sep/09 9:14 PM e.g. Given this code, the following is the result of various Rubys original_constants = Object .constants Kernel::Foo1 = 'foo1' module Kernel Foo2 = 'foo2' end Foo3 = 'foo3' puts ( Object .constants - original_constants).join(', ') ~/Projects/open_source/JRUBY-3144-3399 $ multiruby test7.rb ============================ jruby-working ======================================================= Foo3 ============================ jruby2 ============================================================== Foo3 ============================ ruby-1.8.6-p287-previously-mac-10.5-default-no-ssl ================== Foo3, Foo1, Foo2 ============================ ruby-1.8.6-p369 ===================================================== Foo3, Foo1, Foo2 ============================ ruby-1.8.7-p160 ===================================================== Foo2, Foo3, Foo1 ============================ ruby-1.8.7-p17 ====================================================== Foo2, Foo3, Foo1 ============================ ruby-1.8.7-p174 ===================================================== Foo2, Foo3, Foo1 ============================ ruby-1.8.7-p22 ====================================================== Foo2, Foo3, Foo1 ============================ ruby-1.8.7-p71 ====================================================== Foo2, Foo3, Foo1 ============================ ruby-1.8.7-p72 ====================================================== Foo2, Foo3, Foo1 ============================ ruby-1.8.7-p72-mac-default ========================================== Foo1, Foo2, Foo3 ============================ ruby-1.8.7-preview1 ================================================= Foo2, Foo3, Foo1 ============================ ruby-1.8.7-preview2 ================================================= Foo2, Foo3, Foo1 ============================ ruby-1.8.7-preview3 ================================================= Foo3, Foo1, Foo2 ============================ ruby-1.8.7-preview4 ================================================= Foo3, Foo1, Foo2 ============================ ruby-1.9.1-p0-previously-macports-defualt =========================== Foo3, Foo1, Foo2 ============================ ruby-1.9.1-p129 ===================================================== Foo3, Foo1, Foo2 ============================ ruby-1.9.1-p243-macports ============================================ Foo3, Foo1, Foo2

John F. Douthat added a comment - 12/Sep/09 10:46 PM OK. 1) Constants defined on Kernel do not show up in Object.constants 2) However, you can still fetch the "missing" constants via Object.const_get('ConstantName') 3) Thomas E Enebo is right. When the missing constant is accessed, the file is correctly autoloaded, but it's loaded into the wrong module.

Charles Oliver Nutter added a comment - 10/Sep/12 3:43 PM The first failure is no longer tagged, and the second is...one step forward and one step back. In any case, we don't keep bugs open that just refer to RubySpec tags, since the tags are bug enough.