JRuby

RubySpec: Thread.stop resets Thread.critical to false

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: JRuby 1.2
  • Fix Version/s: JRuby 1.2
  • Component/s: RubySpec
  • Labels:
    None
  • Number of attachments :
    0

Description

     [java] Thread.stop resets Thread.critical to false FAILED
     [java] Expected true
     [java]  to equal false
     [java] 
     [java] /Users/headius/projects/jruby/spec/ruby/core/thread/stop_spec.rb:16
     [java] /Users/headius/projects/jruby/spec/ruby/core/thread/stop_spec.rb:4
     [java] /Users/headius/projects/jruby/spec/ruby/core/thread/stop_spec.rb:54:in `load'

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Charles Oliver Nutter added a comment -

This may be intermittent...a bad spec. I was unable to reproduce to tag it. Must be investigated by 1.2.

Show
Charles Oliver Nutter added a comment - This may be intermittent...a bad spec. I was unable to reproduce to tag it. Must be investigated by 1.2.
Hide
Permalink
Charles Oliver Nutter added a comment -

I was still unable to reproduce this, but I did see that in RubyThread.stop there's a moment where the thread could report it's sleeping but still hold the critical lock. I modified it to release the lock before officially going to sleep, and that should prevent this ever happening again. Fixed in r9238.

Show
Charles Oliver Nutter added a comment - I was still unable to reproduce this, but I did see that in RubyThread.stop there's a moment where the thread could report it's sleeping but still hold the critical lock. I modified it to release the lock before officially going to sleep, and that should prevent this ever happening again. Fixed in r9238.

People

  • Assignee:
    Charles Oliver Nutter
    Reporter:
    Charles Oliver Nutter
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: