JRuby

Wrabler escapes config.ru twice

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: JRuby-extras
  • Labels:
    None
  • Number of attachments :
    0

Description

This bug has a painful workaround: only use single quotes, no >, < and &.

The config.ru used in samples is escaped twice, so elements like:
:environment => "production"
give:
:environment =&gt; &quot;production&quot;

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Nick Sieger added a comment -

This is actually an artifact of a fix in Warbler to escape all web.xml parameters automatically. Thus, you no longer need to manually CGI-escape the contents. The Sinatra example in JRuby-Rack has been updated to reflect this.

Show
Nick Sieger added a comment - This is actually an artifact of a fix in Warbler to escape all web.xml parameters automatically. Thus, you no longer need to manually CGI-escape the contents. The Sinatra example in JRuby-Rack has been updated to reflect this.
Hide
Permalink
Antoine Toulme added a comment -

And you did that in this commit:

http://github.com/nicksieger/jruby-rack/commit/7f19be0b965f99b4e8b4fe98f9f76acadeebe261

Where you removed those lines:

  • require 'cgi'
  • config.webxml.rackup = CGI::escapeHTML(File.read("config.ru"))

Thanks!

Show
Antoine Toulme added a comment - And you did that in this commit: http://github.com/nicksieger/jruby-rack/commit/7f19be0b965f99b4e8b4fe98f9f76acadeebe261 Where you removed those lines:
  • require 'cgi'
  • config.webxml.rackup = CGI::escapeHTML(File.read("config.ru"))
Thanks!

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.