JRuby

New ARGF spec failures

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: JRuby 1.2
  • Component/s: RubySpec
  • Labels:
    None
  • Number of attachments :
    1

Description

Updated specs show new ARGF failures:

fails(JRUBY-3275):ARGF.binmode returns self
fails(JRUBY-3275):ARGF.close closes the current open stream
fails(JRUBY-3275):ARGF.gets modifies the files when in place edit mode is on
fails(JRUBY-3275):ARGF.gets modifies and backups two files when in place edit mode is on
fails(JRUBY-3275):ARGF.readline modifies the files when in place edit mode is on
fails(JRUBY-3275):ARGF.readline modifies and backups two files when in place edit mode is on

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Joseph LaFata added a comment -

Created the patch from the org directory.

I did break FOR in RubyInstantConfig, I'm not 100% sure that's right.

I wasn't able to test this on windows.

Show
Joseph LaFata added a comment - Created the patch from the org directory. I did break FOR in RubyInstantConfig, I'm not 100% sure that's right. I wasn't able to test this on windows.
Hide
Permalink
Thomas E Enebo added a comment -

Fixed in commit 8611. Joseph, I split out the windows and non-windows logic which will not make it as directly comparable against MRI logic, but I think you will agree makes the code look a lot nicer.

Show
Thomas E Enebo added a comment - Fixed in commit 8611. Joseph, I split out the windows and non-windows logic which will not make it as directly comparable against MRI logic, but I think you will agree makes the code look a lot nicer.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.