[#JRUBY-3275] New ARGF spec failures

JRuby

New ARGF spec failures

Created: 31/Dec/08 02:41 AM Updated: 21/Mar/09 01:14 PM

Component/s:

RubySpec

Affects Version/s:

None

Fix Version/s:

JRuby 1.2

Time Tracking:

Not Specified

File Attachments:

argf.patch (8 kB)

Description

« Hide

Updated specs show new ARGF failures:

fails(JRUBY-3275):ARGF.binmode returns self
fails(JRUBY-3275):ARGF.close closes the current open stream
fails(JRUBY-3275):ARGF.gets modifies the files when in place edit mode is on
fails(JRUBY-3275):ARGF.gets modifies and backups two files when in place edit mode is on
fails(JRUBY-3275):ARGF.readline modifies the files when in place edit mode is on
fails(JRUBY-3275):ARGF.readline modifies and backups two files when in place edit mode is on

All

Comments

Work Log

Change History

Sort Order:

[ Permalink | « Hide ]

Joseph LaFata added a comment - 02/Jan/09 04:51 PM

Created the patch from the org directory.

I did break FOR in RubyInstantConfig, I'm not 100% sure that's right.

I wasn't able to test this on windows.

[ Permalink | « Hide ]

Thomas E Enebo added a comment - 06/Jan/09 11:14 AM

Fixed in commit 8611. Joseph, I split out the windows and non-windows logic which will not make it as directly comparable against MRI logic, but I think you will agree makes the code look a lot nicer.