Hpricot uses deprecated and to-be-removed IntHashMap from JRuby

Details

Description

Subject basically says it all. I wanted to clean house, and removed IntHashMap. But JRUBY-3270 shows a case that broke, because something (presumably AR-JDBC) was referencing IntHashMap. IntHashMap is not used by JRuby internally and has been deprecated for quite a while. We would like to delete it, so AR-JDBC should ideally stop using it now. Perhaps we'll be able to remove it NEXT year. Le sigh.

Patch is attached that reinstated IntHashMap. Reverse apply to remove it again.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Stephen Bannasch added a comment -

The problem is not with AR_JDBC.

Hpricot uses IntHashMap in it's JRuby implementation of fast_xs:

http://github.com/why/hpricot/tree/master/ext/fast_xs/FastXsService.java

FastXsService.java is compiled into fast_xs.jar and distributed with Hpricot.

Rails activesupport extends String with a XML escaped character version of #to_s called #to_xs and will use fast_xs if it is available:

http://github.com/rails/rails/tree/master/activesupport/lib/active_support/core_ext/string/xchar.rb

When hpricot is installed in a JRuby instance fast_xs is available.

Several of the AR tests exercise this method

FYI: nicksieger did the coding on FastXsService.java

http://caldersphere.net/hpricot-0.6.157-jruby-trunk.patch

Show
Stephen Bannasch added a comment - The problem is not with AR_JDBC. Hpricot uses IntHashMap in it's JRuby implementation of fast_xs: http://github.com/why/hpricot/tree/master/ext/fast_xs/FastXsService.java FastXsService.java is compiled into fast_xs.jar and distributed with Hpricot. Rails activesupport extends String with a XML escaped character version of #to_s called #to_xs and will use fast_xs if it is available: http://github.com/rails/rails/tree/master/activesupport/lib/active_support/core_ext/string/xchar.rb When hpricot is installed in a JRuby instance fast_xs is available. Several of the AR tests exercise this method FYI: nicksieger did the coding on FastXsService.java http://caldersphere.net/hpricot-0.6.157-jruby-trunk.patch
Hide
Permalink
Thomas E Enebo added a comment -

Changed this to reflect that it is for hpricot and not AR-JDBC

Show
Thomas E Enebo added a comment - Changed this to reflect that it is for hpricot and not AR-JDBC
Hide
Permalink
Charles Oliver Nutter added a comment -

Change title to spell Hpricot correctly

Show
Charles Oliver Nutter added a comment - Change title to spell Hpricot correctly
Hide
Permalink
Charles Oliver Nutter added a comment -

If we still use it...we could easily remove it.

Show
Charles Oliver Nutter added a comment - If we still use it...we could easily remove it.
Hide
Permalink
Ola Bini added a comment -

I have modified Hpricot to no longer use JRuby's IntHashMap, but of course we still need to have it in JRuby until a new version of Hpricot has been released. Leaving this bug open until that point.

Show
Ola Bini added a comment - I have modified Hpricot to no longer use JRuby's IntHashMap, but of course we still need to have it in JRuby until a new version of Hpricot has been released. Leaving this bug open until that point.
Hide
Permalink
Thomas E Enebo added a comment -

Hpricot no longer uses this class, but our profiler code does now. I assume we undeprecated it. wont-fixing.

Show
Thomas E Enebo added a comment - Hpricot no longer uses this class, but our profiler code does now. I assume we undeprecated it. wont-fixing.

People

  • Assignee:
    Thomas E Enebo
    Reporter:
    Charles Oliver Nutter
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: