|
From
A few more interesting cases: ~/projects/jruby ➔ ruby -Ifoo -e "require 'bar'" ./foo/bar.rb:1: unhandled exception from -e:1:in `require' from -e:1 ~/projects/jruby ➔ ruby -e "require 'foo/bar'" ./foo/bar.rb:1: unhandled exception from -e:1:in `require' from -e:1 ~/projects/jruby ➔ ruby -e "require './foo/bar'" ./foo/bar.rb:1: unhandled exception from -e:1:in `require' from -e:1 Note that, while not immediately apparent here, Ruby does appear to attempt to certain paths as-is before trying load paths, and does not appear to ever attach load paths to absolute paths (which makes some sense). So adding a short-circuit that tries the path as-is first seems to also be in the cards. From
A couple more, showing Ruby does not attempt to search load path for a relative path based on . (CWD): First with no bar.rb in current dir, but a bar.rb in the 'foo' dir: ~/projects/jruby ➔ ruby -Ifoo -e "require './bar.rb'" -e:1:in `require': no such file to load -- ./bar.rb (LoadError) from -e:1 Now with a bar.rb in current dir: ~/projects/jruby ➔ echo puts \'hello\' > bar.rb ~/projects/jruby ➔ ruby -Ifoo -e "require './bar.rb'" hello Obviously we need to put together specs for all the many cases. A few more that need to be specified:
Others? From
Note the difference between these two traces: Ruby: ./test2.rb:3: unhandled exception from test1.rb:2:in `require' from test1.rb:2 JRuby: /Users/headius/NetBeansProjects/jruby/./test2.rb:3:in `(unknown)': unhandled exception from /Users/headius/NetBeansProjects/jruby/./test2.rb:2:in `require' from test1.rb:2:in `(unknown)' LoadService is currently expanding paths to their full absolute path (and in some cases, to their canonical non-symlinked path) before passing the file off to be parsed and loaded. This is largely why backtraces, trace events, compiled package names, and so on have the full path. Tom Enebo fixed the parser in the last release to not use long paths, and it seems that currently the only remaining issue is in the load process. See also
From
Here's the breakdown: #=== file_test.rb ===
puts "__FILE__: #{__FILE__}"
puts "File.dirname(__FILE__): #{File.dirname(__FILE__)}"
puts "File.expand_path(File.dirname(__FILE__)): #{File.expand_path(File.dirname(__FILE__))}"
#=== bootstrap1.rb === (used to test uncompiled Ruby files in a jar)
require 'file_test'
#=== bootstrap2.rb === (used to test uncompiled Ruby files in a jar)
require 'src/file_test'
# GIVES CORRECT OUTPUT
#=== Running the file_test.rb file unmodified using MRI and JRuby ===
ruby file_test.rb
__FILE__: file_test.rb
File.dirname(__FILE__): .
File.expand_path(File.dirname(__FILE__)): /Users/david/dev/projects/general/jruby_test
jruby file_test.rb
__FILE__: file_test.rb
File.dirname(__FILE__): .
File.expand_path(File.dirname(__FILE__)): /Users/david/dev/projects/general/jruby_test
# GIVES CORRECT OUTPUT
# === Compile the file_test.rb file (jrubyc file_test.rb) ===
java -cp ~/dev/libs/jruby/lib/jruby.jar:. file_test
__FILE__: file_test.rb
File.dirname(__FILE__): .
File.expand_path(File.dirname(__FILE__)): /Users/david/dev/projects/general/jruby_test
# GIVES INCORRECT OUTPUT
# === Jarring the file_test.rb (jar -cvf file_test.jar file_test.rb bootstrap1.class) and placing jar file in /jar sub-directory ===
# Adding in compiled bootstrap1 class so java has something to launch
java -cp ~/dev/libs/jruby/lib/jruby-complete.jar:file_test.jar bootstrap1 #<-- no output, internally an exception?
# GIVES INCORRECT OUTPUT
# === Jarring the file_test.class (jar -cvf file_test.jar file_test.class) (also placing in /jar sub-directory) ===
# Moved file_test.jar into /jar subdirectory to prevent accidentally pulling in .class file
java -cp ~/dev/libs/jruby/lib/jruby-complete.jar:file_test.jar file_test
__FILE__: file_test.rb
File.dirname(__FILE__): .
File.expand_path(File.dirname(__FILE__)): /Users/david/dev/projects/general/jruby_test/jar #<-- should have /file_test.jar! on the end
GIVES CORRECT OUTPUT
# === Uncompiled Ruby file in /src directory in jar file ===
# Use bootstrap2 file to require file in 'src/test_file'
java -cp ~/dev/libs/jruby/lib/jruby-complete.jar:file_test.jar bootstrap2
__FILE__: file:/Users/david/dev/projects/general/jruby_test/jar/file_test.jar!/src/file_test.rb
File.dirname(__FILE__): file:/Users/david/dev/projects/general/jruby_test/jar/file_test.jar!/src
File.expand_path(File.dirname(__FILE__)): file:/Users/david/dev/projects/general/jruby_test/jar/file_test.jar!/src #<-- We get the jar file and the sub-dir, yay!
GIVES INCORRECT OUTPUT
# === Compiled Ruby file in /src directory in jar file ===
# As above but with compiled Ruby file, same bootstrap2 file
java -cp ~/dev/libs/jruby/lib/jruby-complete.jar:file_test.jar bootstrap2
__FILE__: file_test.rb
File.dirname(__FILE__): .
File.expand_path(File.dirname(__FILE__)): /Users/david/dev/projects/general/jruby_test/jar #<-- missing /file_test.jar!/src
Still need specs, and there's still outstanding bugs relating to require (like the fact that it always tries cwd even if . isn't in load path).
There are a lot of new specs in RubySpec for load stuff, but we need some of our own for URLs, jar files, all that. It's still fuzzily covered.
|
||||||||||||||||||||||||||||||||||||||||||
 |
|
Bug
Open
Major
Specs for all load path, load/require, home dir, url, and other load-logic cases
JRUBY-2909:It seems that largely, Ruby leaves relative paths relative and absolute paths absolute, using those literal paths in logging and traces. It also resolves relative paths dynamically at runtime based on the process CWD:
~/projects/jruby ➔ ruby -Ifoo -e "require 'bar'" ./foo/bar.rb:1: unhandled exception from -e:1:in `require' from -e:1 ~/projects/jruby ➔ cd foo ~/projects/jruby/foo ➔ ruby -e "require 'bar'" ./bar.rb:1: unhandled exception from -e:1:in `require' from -e:1 ~/projects/jruby/foo ➔ cd ../lib ~/projects/jruby/lib ➔ ruby -I../foo -e "require 'bar'" ../foo/bar.rb:1: unhandled exception from -e:1:in `require' from -e:1 ~/projects/jruby/lib ➔ ruby -I../../jruby/foo -e "require 'bar'" ../../jruby/foo/bar.rb:1: unhandled exception from -e:1:in `require' from -e:1 ~/projects/jruby/lib ➔ ruby -I/Users/headius/projects/jruby/foo -e "require 'bar'" /Users/headius/projects/jruby/foo/bar.rb:1: unhandled exception from -e:1:in `require' from -e:1 ~/projects/jruby/lib ➔ cd .. ~/projects/jruby ➔ ruby -Ifoo -e "Dir.chdir('lib'); require 'bar'" -e:1:in `require': no such file to load -- bar (LoadError) from -e:1So our problem, and the reason why we always seem to have full paths in traces, is that we always turn paths into absolute paths, losing that original short path. This also represents a behavioral difference; notice in the last case that when the CWD is changed, relative paths no longer resolve the same.