JRuby

Private constructors on org.jruby.RubyString effectively cutoff subclassing

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: JRuby 1.1.4
  • Fix Version/s: JRuby 1.1.5
  • Component/s: Java Integration
  • Labels:
    None
  • Environment:
    Jruby 1.1.4
  • Number of attachments :
    1

Description

All constructors on org.jruby.RubyString are private. Any subclass would need to call these constructors to be able to do any meaningful work. The fix, I imagine, would be to mark these constructors as protected.

-Chad Johnson

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Chad Johnson added a comment -

A simple patch marking these constructors as protected

Show
Chad Johnson added a comment - A simple patch marking these constructors as protected
Hide
Permalink
Ola Bini added a comment -

Fixed on trunk. I didn't see any reason to restrict it to protected, so I made them public instead.

Show
Ola Bini added a comment - Fixed on trunk. I didn't see any reason to restrict it to protected, so I made them public instead.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.