[#JRUBY-3039] Private constructors on org.jruby.RubyString effectively cutoff subclassing

JRuby

Private constructors on org.jruby.RubyString effectively cutoff subclassing

Created: 05/Oct/08 04:47 PM Updated: 12/Jan/09 04:28 PM

Component/s:

Java Integration

Affects Version/s:

JRuby 1.1.4

Fix Version/s:

JRuby 1.1.5

Time Tracking:

Not Specified

File Attachments:	1. RubyString_protected_constructors.patch (1 kB)
Environment:	Jruby 1.1.4

Description

« Hide

All constructors on org.jruby.RubyString are private. Any subclass would need to call these constructors to be able to do any meaningful work. The fix, I imagine, would be to mark these constructors as protected.

-Chad Johnson

All

Comments

Work Log

Change History

Sort Order:

[ Permalink | « Hide ]

Chad Johnson added a comment - 06/Oct/08 10:06 AM

A simple patch marking these constructors as protected

[ Permalink | « Hide ]

Ola Bini added a comment - 17/Oct/08 04:26 AM

Fixed on trunk. I didn't see any reason to restrict it to protected, so I made them public instead.