[#JRUBY-2949] jdbcderby adapter should ignore :limit for INTEGER - jira.codehaus.org

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: None
Component/s: None
Labels:
None
Environment:
Fedora Linux 9, Sun Java 1.6.0_06, JRuby trunk (rev 8935), DerbyDB 10.2.2.0

Number of attachments :
0

Description

When giving a :limit => 4 option to an integer field in a migration, and running it agawinst a berdy database, the generated DDL is converted to a INTEGER(4) type. Derby does not support this and fails. The jdbcderby adapter should ignore the :limit option for integers.

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Uwe Kubosch added a comment - 27/Aug/08 6:49 AM

I have a fix:

Add the following section at the bottom of

lib/active_record/connection_adapters/derby_adapter.rb

module ActiveRecord
module ConnectionAdapters # :nodoc:
module SchemaStatements

Ignore limit for INTEGER types since Derby/JavaDB does not understand this.
def type_to_sql_with_suppress_integer_limit(type, limit = nil, precision = nil, scale = nil) #:nodoc:
type_to_sql_without_suppress_integer_limit(type, type == :integer ? nil : limit, precision, scale)
end
alias_method_chain :type_to_sql, :suppress_integer_limit
end
end
end

Show

Uwe Kubosch added a comment - 27/Aug/08 6:49 AM I have a fix: Add the following section at the bottom of lib/active_record/connection_adapters/derby_adapter.rb module ActiveRecord module ConnectionAdapters # :nodoc: module SchemaStatements

Ignore limit for INTEGER types since Derby/JavaDB does not understand this. def type_to_sql_with_suppress_integer_limit(type, limit = nil, precision = nil, scale = nil) #:nodoc: type_to_sql_without_suppress_integer_limit(type, type == :integer ? nil : limit, precision, scale) end alias_method_chain :type_to_sql, :suppress_integer_limit end end end

Hide

Permalink

Uwe Kubosch added a comment - 27/Aug/08 6:53 AM

module ActiveRecord
module ConnectionAdapters # :nodoc:
module SchemaStatements

Ignore limit for INTEGER types since Derby/JavaDB does not understand this.
def type_to_sql_with_suppress_integer_limit(type, limit = nil, precision = nil, scale = nil) #:nodoc:
type_to_sql_without_suppress_integer_limit(type, type == :integer ? nil : limit, precision, scale)
end
alias_method_chain :type_to_sql, :suppress_integer_limit
end
end
end
<noformat}

Show

Uwe Kubosch added a comment - 27/Aug/08 6:53 AM

module ActiveRecord module ConnectionAdapters # :nodoc: module SchemaStatements

Ignore limit for INTEGER types since Derby/JavaDB does not understand this. def type_to_sql_with_suppress_integer_limit(type, limit = nil, precision = nil, scale = nil) #:nodoc: type_to_sql_without_suppress_integer_limit(type, type == :integer ? nil : limit, precision, scale) end alias_method_chain :type_to_sql, :suppress_integer_limit end end end <noformat}

Hide

Permalink

Uwe Kubosch added a comment - 27/Aug/08 6:54 AM

Sorry for the stupid formatting. Here we are:

module ActiveRecord
  module ConnectionAdapters # :nodoc:
    module SchemaStatements
      # Ignore limit for INTEGER types since Derby/JavaDB does not understand this.
      def type_to_sql_with_suppress_integer_limit(type, limit = nil, precision = nil, scale = nil) #:nodoc:
        type_to_sql_without_suppress_integer_limit(type, type == :integer ? nil : limit, precision, scale)
      end
      alias_method_chain :type_to_sql, :suppress_integer_limit
    end
  end
end

Show

Uwe Kubosch added a comment - 27/Aug/08 6:54 AM Sorry for the stupid formatting. Here we are:

module ActiveRecord
  module ConnectionAdapters # :nodoc:
    module SchemaStatements
      # Ignore limit for INTEGER types since Derby/JavaDB does not understand this.
      def type_to_sql_with_suppress_integer_limit(type, limit = nil, precision = nil, scale = nil) #:nodoc:
        type_to_sql_without_suppress_integer_limit(type, type == :integer ? nil : limit, precision, scale)
      end
      alias_method_chain :type_to_sql, :suppress_integer_limit
    end
  end
end

Hide

Permalink

Thomas E Enebo added a comment - 29/Jan/09 5:52 PM

I fixed this the other day for derby. For posterity the logic:

    def type_to_sql(type, limit = nil, precision = nil, scale = nil) #:nodoc:
      return super unless type == :integer

      native = native_database_types[type.to_s.downcase.to_sym]
      native.is_a?(Hash) ? native[:name] : native
    end

Show

Thomas E Enebo added a comment - 29/Jan/09 5:52 PM I fixed this the other day for derby. For posterity the logic:

    def type_to_sql(type, limit = nil, precision = nil, scale = nil) #:nodoc:
      return super unless type == :integer

      native = native_database_types[type.to_s.downcase.to_sym]
      native.is_a?(Hash) ? native[:name] : native
    end

People

Assignee:

Thomas E Enebo

Reporter:

Uwe Kubosch

Vote (0)

Watch (0)

Dates

Created:

27/Aug/08 1:59 AM

Updated:

25/Aug/09 11:34 AM

Resolved:

29/Jan/09 5:52 PM

JRuby

jdbcderby adapter should ignore :limit for INTEGER

Details

Description

Activity

People

Dates