JRuby

Create caching mechanism for all our many calls to callMethod from Java code

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: JRuby 1.1.5
  • Component/s: Performance
  • Labels:
    None
  • Number of attachments :
    0

Description

It seems like more and more our constant use of IRubyObject.callMethod is eating up a lot of performance dark matter. Because we use these for calculating hashes, checking equality, coercing objects, and so much more, we need a way to either inline cache or provide a per-class or global cache. I have a suspicion that it could help performance substantially.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Charles Oliver Nutter added a comment -

Damn, no way this will get in for 1.1.3. Punting.

Show
Charles Oliver Nutter added a comment - Damn, no way this will get in for 1.1.3. Punting.
Hide
Permalink
Charles Oliver Nutter added a comment -

Some of this has been helped by our per-class method cache being reinstated, This improved the cost of calls from Java code to Ruby code significantly, since in most cases it's now a single hash hit. But we still could benefit from a caching mechanism more localized to the callers, to allow them to cache an immediate reference to a method.

Show
Charles Oliver Nutter added a comment - Some of this has been helped by our per-class method cache being reinstated, This improved the cost of calls from Java code to Ruby code significantly, since in most cases it's now a single hash hit. But we still could benefit from a caching mechanism more localized to the callers, to allow them to cache an immediate reference to a method.
Hide
Permalink
Charles Oliver Nutter added a comment -

We implemented a per-class cache in 1.1.5 that has greatly improves performance of arbitrary calls. There's more we could do, but we'll get to it (and file bugs for it if necessary) later.

Show
Charles Oliver Nutter added a comment - We implemented a per-class cache in 1.1.5 that has greatly improves performance of arbitrary calls. There's more we could do, but we'll get to it (and file bugs for it if necessary) later.

People

  • Assignee:
    Charles Oliver Nutter
    Reporter:
    Charles Oliver Nutter
Vote (1)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: