History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: JRUBY-2765
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Charles Oliver Nutter
Reporter: Charles Oliver Nutter
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
JRuby

Attr assign for block arguments is still slow, both in bytecode and in not call-site caching

Created: 08/Jul/08 04:51 PM   Updated: Yesterday 11:15 PM
Component/s: Compiler
Affects Version/s: None
Fix Version/s: JRuby 1.1.5

Time Tracking:
Not Specified


 Description  « Hide
I added a fixme for this some time ago, stating that it's not really important for attr assign in multiple assignment to be fast, but I'd like to circle back now and fix it to have more optimal logic with call site caching and stuff. The charlie library (see JRUBY-2403) appears to hit this path in a few places. It's not likely to be a key source of performance improvement, but it would be one less thing to worry about and for cases where it is being used it will be a lot faster.

See compiledAttrAssignAssignment in ASTCompiler and everything it calls.



 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Charles Oliver Nutter - 16/Jul/08 02:52 AM
No compiler rework two days before release. Punting.

Charles Oliver Nutter - 06/Oct/08 11:15 PM
Fixed for 1.1.5 along with some cleanup for other related constructs (attr assign, op * assign, etc).