JRuby (please use github issues at http://bugs.jruby.org)
  1. JRuby (please use github issues at http://bugs.jruby.org)
  2. JRUBY-2745

Revive test_trace_func.rb tests and provide test:interpreter Rake task

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: JRuby 1.1.3
    • Component/s: Interpreter
    • Labels:
      None
    • Number of attachments :
      1

      Description

      I've already done so on my local machine and using tests for jruby-debug-base. But they really belongs to the JRuby code base. So I'll provide a patch. But current tests are too tweaked, since there are some pending bugs in the interpreter. I'll wait at least for JRUBY-2744 to be fixed and then I'll attach a patch here.

        Activity

        Hide
        Charles Oliver Nutter added a comment -

        A fix has been committed for JRUBY-2744...so hopefully we can get tests enabled again.

        Show
        Charles Oliver Nutter added a comment - A fix has been committed for JRUBY-2744 ...so hopefully we can get tests enabled again.
        Hide
        Martin Krauskopf added a comment -

        Thanks for quick fixes in the tracing area Charlie. I'm attaching the 'revived' tracing tests. So far, there is a:

        • new test:tracing task in the Rakefile which must be run with --debug flag, like
          jruby --debug `which rake` test:tracing
          or using -S flag for JRuby.
        • I've moved tracing test to test/tracing directory with few other 'data' files.
        • utilizing _LINE_ instead of hard-coded line information so one can freely edit current test and add new ones to the test_trace_func.rb without the need for fixing line int the whole file, which was painful.

        Current situation is quite good. All test passing on Ruby and only two failures with JRuby (2008-07-04 rev 7101).

        • the full path problem tracked under JRUBY-2722
        • and the problem with c-return of require method under certain circumstance. I've did not check the impact on the debugger. Will file as a separate issue with more information soon.
        Show
        Martin Krauskopf added a comment - Thanks for quick fixes in the tracing area Charlie. I'm attaching the 'revived' tracing tests. So far, there is a: new test:tracing task in the Rakefile which must be run with --debug flag, like jruby --debug `which rake` test:tracing or using -S flag for JRuby. I've moved tracing test to test/tracing directory with few other 'data' files. utilizing _ LINE _ instead of hard-coded line information so one can freely edit current test and add new ones to the test_trace_func.rb without the need for fixing line int the whole file, which was painful. Current situation is quite good. All test passing on Ruby and only two failures with JRuby (2008-07-04 rev 7101). the full path problem tracked under JRUBY-2722 and the problem with c-return of require method under certain circumstance. I've did not check the impact on the debugger. Will file as a separate issue with more information soon.
        Hide
        Charles Oliver Nutter added a comment -

        Wire up tests before 1.1.3.

        Show
        Charles Oliver Nutter added a comment - Wire up tests before 1.1.3.
        Hide
        Charles Oliver Nutter added a comment -

        I've added all the tests and they run as expected, with the only failure being the "full path" problem from JRUBY-2722. Thanks very much!

        Show
        Charles Oliver Nutter added a comment - I've added all the tests and they run as expected, with the only failure being the "full path" problem from JRUBY-2722 . Thanks very much!

          People

          • Assignee:
            Charles Oliver Nutter
            Reporter:
            Martin Krauskopf
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: