JRuby

Interpreter passes absolute path to the EventHook for 'require'ed files

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: JRuby 1.1.2
  • Fix Version/s: JRuby 1.1.3
  • Component/s: Parser
  • Labels:
    None
  • Environment:
    Trunk rev. 7052.
  • Testcase included:
    yes
  • Number of attachments :
    1

Description

Influence debugger-like tools. Apply the attached test case and run:

./bin/jruby --debug test/test_trace_func.rb

Likely commenting-out other test then test_require_trace before.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Charles Oliver Nutter added a comment -

This is largely a parser issue. The trace functions just get whatever position information we have in the AST, provided by the parser. Note that this also affects things like jitted package name (based on filename), exception backtraces (using position information) and so on, bloating them up substantially. Really would be nice to get fixed.

Maybe for 1.1.3, if Tom has ideas for fixing it.

Show
Charles Oliver Nutter added a comment - This is largely a parser issue. The trace functions just get whatever position information we have in the AST, provided by the parser. Note that this also affects things like jitted package name (based on filename), exception backtraces (using position information) and so on, bloating them up substantially. Really would be nice to get fixed. Maybe for 1.1.3, if Tom has ideas for fixing it.
Hide
Permalink
Martin Krauskopf added a comment -

Tom, the test attached here might be ignored, if JRUBY-2745 is integrated. There is already (failing) 'test_require_trace_full_paths' included.

Show
Martin Krauskopf added a comment - Tom, the test attached here might be ignored, if JRUBY-2745 is integrated. There is already (failing) 'test_require_trace_full_paths' included.
Hide
Permalink
Charles Oliver Nutter added a comment -

I've got a feeling this isn't going to get fixed for 1.1.3, since I've been nagging Tom about it for quite a while...it's not a trivial fix.

Show
Charles Oliver Nutter added a comment - I've got a feeling this isn't going to get fixed for 1.1.3, since I've been nagging Tom about it for quite a while...it's not a trivial fix.
Hide
Permalink
Thomas E Enebo added a comment -

Fixed in 7198 on trunk. The problem is in how LoadService provides files to the parser. I fixed two places where the test fails, but there could be more...I think we will need to do yet another refactoring on this stuff next cycle.

Show
Thomas E Enebo added a comment - Fixed in 7198 on trunk. The problem is in how LoadService provides files to the parser. I fixed two places where the test fails, but there could be more...I think we will need to do yet another refactoring on this stuff next cycle.
Hide
Permalink
Charles Oliver Nutter added a comment -

Sorry to do this to you again, Tom, but the new changes appear to break rake spec:ji and I've reverted them (got a JI patch I'd lke to try to get in for 1.1.3 and I'm sitting here unable to test it).

One more try?

Show
Charles Oliver Nutter added a comment - Sorry to do this to you again, Tom, but the new changes appear to break rake spec:ji and I've reverted them (got a JI patch I'd lke to try to get in for 1.1.3 and I'm sitting here unable to test it). One more try?
Hide
Permalink
Charles Oliver Nutter added a comment -

Shite. I was still on the old version. Damn our rapid development process! Luckily I was able to back out the local commit before I pushed, so no reversion ever made it to the repo. Deepest apologies...rake spec:ji runs fine with your more recent fix.

Show
Charles Oliver Nutter added a comment - Shite. I was still on the old version. Damn our rapid development process! Luckily I was able to back out the local commit before I pushed, so no reversion ever made it to the repo. Deepest apologies...rake spec:ji runs fine with your more recent fix.

People

  • Assignee:
    Thomas E Enebo
    Reporter:
    Martin Krauskopf
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: