Request body is empty (POST) if Tomcat RequestDumperValve is enabled

Michael König added a comment - 22/Jun/08 4:05 PM I have modified method 'parse_formatted_request_parameters' of class 'ActionController::AbstractRequest '(in actionpack 2.1.0, ...\action_controller\request.rb) With this code: puts ">>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>" puts "request_uri: #{request_uri}" puts "mime_type: #{mime_type}" puts "strategy: #{strategy}" puts "has raw_post_data?: #{env.include? 'RAW_POST_DATA'}" puts "self.body.to_s: #{self.body.to_s}" puts "self.body.class: #{self.body.class}" puts "content_length: #{content_length}" puts "body.to_s: #{body.to_s}" puts "body.class: #{body.class}" puts "<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<" With RequestDumperValve disabled, everything works fine. The Result in my console-window looks as expected: >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> request_uri: /dc/user_settings/dispatch_events mime_type: application/x-www-form-urlencoded strategy: url_encoded_form has raw_post_data?: false self.body.to_s: #<IO:0xa5852> self.body.class: IO content_length: 66 body.to_s: event_name=getContent&target_window_id=7&desklet_name=UserSettings body.class: String <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< Now, I have enabled the RequestDumperValve... the result was: >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> request_uri: /dc/user_settings/dispatch_events mime_type: application/x-www-form-urlencoded strategy: url_encoded_form has raw_post_data?: false self.body.to_s: #<IO:0xc0d228> self.body.class: IO content_length: 66 body.to_s: body.class: NilClass <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> request_uri: /dc/user_settings/dispatch_events mime_type: application/x-www-form-urlencoded strategy: url_encoded_form has raw_post_data?: false self.body.to_s: #<IO:0xc0d228> self.body.class: IO content_length: 66 body.to_s: body.class: NilClass <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< two things have changed: first, the body is nil; second, the method seems to be called twice!? Whatever I've tried in method 'raw_post' - I wasn't able to read the data... btw. this problem is not specific to RequestDumperValve, but also occures with any valve... im my sample the 'invoke' method of my valve looks loike that: public void invoke(Request request, Response response) throws IOException, ServletException { // everything works fine if next line is commentet out!!! request.getParameter( "myTestParam" ); // not our game getNext().invoke(request, response); } // end method invoke And... i've a second web-app deployed on this server, using plain old java with struts actions, and this webapp also works fine! ps: i work with JRuby 1.1.2; Rails 2.1.0; Goldspike 1.6.1;

Charles Oliver Nutter added a comment - 03/Jul/08 10:45 AM Very odd. Can you explain a bit how the valves work? Do you have any theories why this interferes with the POST getting through correctly? You might want to try using Warbler, which has a completely rewritten request pipeline.

harry wang added a comment - 22/Jan/09 12:48 AM I met a similar problem when using jruby and warbler to deploy my ruby on rails app to resin and set some servlet filter before the RackFilter in the web.xml.erb. After some study, I found that the servlet filter call request.getParameter() function, and the function would extract value from HTTP POST body to request parametar map. So when the request was sent to ruby on rails app, it cannot process the POST request correctly. You can see this link http://java.boot.by/wcd-guide/ch01s02.html to get more information about request.getParameter. My method to solve the problem is that I write a HttpServletRequestWrapper sub-class and two servlet filters. In the wrapper class, I return empty or null in the getParameter, getParameterValues, getParameterMap, getParameterNames functions' body to avoid to call the real request's function. The first servlet filter will wrap HttpServletRequest to the wrapper object if request is HTTP POST. The second will unwrap it to get the original HttpServletRequest object and send it to the chain. Then set the first servlet filter at the first of web.xml.erb, and set the second servlet filter just before RackFilter. All is OK after these works. Hope these could give some help.

Richard J Finegan added a comment - 03/Mar/09 12:31 PM i just got burned by this one too - a custom valve in my case, jruby 1.1.6, warbler 0.9.11, tomcat 6.0.16, rails 2.2.2 ... as a workaround in my case i just disabled the valve since it wasn't crucial to the application

Karthik Krishnan added a comment - 17/Dec/09 8:43 AM We have encountered the same issue under load test scenario, even with 2 concurrent users. JRuby Version 1.3.1. Glassfish v2 JRuby Rack 0.9.2 On googling, we found the same issue reported by Jay McGaffigan in the link below : http://tinyurl.com/yzbqn6t It would be good if someone who has appropriate permissions, can edit the issue to update the affected version and update the severity to CRITICAL.

Nick Sieger added a comment - 18/Dec/09 11:57 AM Karthik: Can you try upgrading jruby-rack to the latest (0.9.5)? There were some concurrency issues in previous versions that should be fixed. You should be able to just replace the 0.9.2 jar with 0.9.5 with no further changes.

Hiro Asari added a comment - 08/May/11 9:04 PM The components involved in this issue are too old to really test now.