Make fields immutable where possible

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Won't Fix
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: Miscellaneous
  • Labels:
    None

Description

There are a lot of places where instance or class variables could be made immutable.

  1. Text File
    org.jruby.ext.patch
    19/Apr/08 4:55 PM
    6 kB
    Wayne Meissner
  2. Text File
    org.jruby.internal.patch
    19/Apr/08 4:55 PM
    16 kB
    Wayne Meissner
  3. Text File
    org.jruby.javasupport.patch
    19/Apr/08 4:54 PM
    4 kB
    Wayne Meissner
  4. Text File
    org.jruby.patch
    19/Apr/08 4:59 PM
    11 kB
    Wayne Meissner
  5. Text File
    org.jruby.runtime.patch
    19/Apr/08 4:54 PM
    10 kB
    Wayne Meissner
  6. Text File
    org.jruby.util.patch
    19/Apr/08 4:53 PM
    13 kB
    Wayne Meissner

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Wayne Meissner added a comment -

immutable field sweep for org.jruby.util

Show
Wayne Meissner added a comment - immutable field sweep for org.jruby.util
Hide
Permalink
Charles Oliver Nutter added a comment -

It seems like this is worth the effort, if only to help delineate fields we really don't want to be mutable. As far as I know there's still not really any perf benefit from final fields, other than static finals that can be folded away. But the immutability aspect could lead to cleaner, safer changes in the future.

Show
Charles Oliver Nutter added a comment - It seems like this is worth the effort, if only to help delineate fields we really don't want to be mutable. As far as I know there's still not really any perf benefit from final fields, other than static finals that can be folded away. But the immutability aspect could lead to cleaner, safer changes in the future.
Hide
Permalink
Thomas E Enebo added a comment -

It does also help for threading, but for most/all of these I do not think that would matter. This patch seems to be all about documenting the attribute itself.

Show
Thomas E Enebo added a comment - It does also help for threading, but for most/all of these I do not think that would matter. This patch seems to be all about documenting the attribute itself.
Hide
Permalink
Wayne Meissner added a comment -

These patches are just targetted at cleaning up the code a bit - no operational changes. Hopefully having all the 'easily' immutable fields made so, will make it easier to spot & make changes that do affect things (especially wrt threading and data visibility).

Show
Wayne Meissner added a comment - These patches are just targetted at cleaning up the code a bit - no operational changes. Hopefully having all the 'easily' immutable fields made so, will make it easier to spot & make changes that do affect things (especially wrt threading and data visibility).
Hide
Permalink
Thomas E Enebo added a comment -

I am not against marking final fields where reasonable, but Wayne is a comitter now and can do this piecemeal without needing an issue for this (plus I bet these patches are stale).

Show
Thomas E Enebo added a comment - I am not against marking final fields where reasonable, but Wayne is a comitter now and can do this piecemeal without needing an issue for this (plus I bet these patches are stale).

People

  • Assignee:
    Thomas E Enebo
    Reporter:
    Wayne Meissner
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: