JRuby

The private keyword doesn't change visiblity of previously called methods with same send/call site

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: JRuby 1.1
  • Fix Version/s: JRuby 1.1.6
  • Component/s: Core Classes/Modules
  • Labels:
    None
  • Environment:
    Latest JRuby 1.1
  • Number of attachments :
    0

Description

Yet another new rubyspec failure:

#> bin/mspec ci -t j -X /opt/work/jruby.git/test/spec_excludes spec/ruby/1.8/language/private_spec.rb
....F

1)
The private keyword changes visiblity of previously called methods with same send/call site FAILED
Expected NoMethodError but no exception was raised
/opt/work/rbx.git/./mspec/expectations.rb:10:in `fail_with'
/opt/work/rbx.git/./mspec/expectations/should.rb:6:in `should'
/opt/work/rbx.git/./spec/ruby/1.8/language/private_spec.rb:43:in `/opt/work/rbx.git/./spec/ruby/1.8/language/private_spec.rb'
/opt/work/rbx.git/./mspec/runner/mspec.rb:112:in `call'
/opt/work/rbx.git/./mspec/runner/mspec.rb:112:in `protect'
/opt/work/rbx.git/./mspec/runner/state.rb:46:in `each'
/opt/work/rbx.git/./mspec/runner/state.rb:46:in `protect'
/opt/work/rbx.git/./mspec/runner/state.rb:60:in `process'
/opt/work/rbx.git/./mspec/runner/state.rb:56:in `each'
/opt/work/rbx.git/./mspec/runner/state.rb:56:in `process'
/opt/work/rbx.git/./mspec/runner/mspec.rb:19:in `describe'
/opt/work/rbx.git/./mspec/runner/object.rb:11:in `describe'
/opt/work/rbx.git/./spec/ruby/1.8/language/private_spec.rb:4:in `/opt/work/rbx.git/./spec/ruby/1.8/language/private_spec.rb'
/opt/work/rbx.git/./spec/ruby/1.8/language/private_spec.rb:37:in `load'
/opt/work/rbx.git/./mspec/runner/mspec.rb:37:in `files'
/opt/work/rbx.git/./mspec/runner/mspec.rb:112:in `call'
/opt/work/rbx.git/./mspec/runner/mspec.rb:112:in `protect'
/opt/work/rbx.git/./mspec/runner/mspec.rb:37:in `files'
/opt/work/rbx.git/./mspec/runner/mspec.rb:34:in `each'
/opt/work/rbx.git/./mspec/runner/mspec.rb:34:in `files'
/opt/work/rbx.git/./mspec/runner/mspec.rb:26:in `process'
mspec/bin/mspec-ci:59

Finished in 0.114000 seconds

1 file, 5 examples, 11 expectations, 1 failure, 0 errors

Activity

Hide
Charles Oliver Nutter added a comment -

This was resolved some time ago with our move to passively-invalidated call sites.

Show
Charles Oliver Nutter added a comment - This was resolved some time ago with our move to passively-invalidated call sites.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: