[#JRUBY-2250] Fixnum#>> and Bignum#>> should not raise RangeError when the given argument is out of range of Integer

JRuby

Fixnum#>> and Bignum#>> should not raise RangeError when the given argument is out of range of Integer

Created: 10/Mar/08 11:41 AM Updated: 20/May/08 01:48 PM

Component/s:

Core Classes/Modules

Affects Version/s:

JRuby 1.1RC2

Fix Version/s:

JRuby 1.1+

Time Tracking:

Not Specified

Environment:

Latest JRuby 1.1RC2

Description

« Hide

The title says it all. Right shift for very large values should not raise RangeError, but rather return 0 for positive value and -1 for negative one.

This leads to two rubyspec failures:
Fixnum#>> does not raise RangeError when the given argument is out of range of Integer
Bignum#>> does not raise RangeError when the given argument is out of range of Integer

All

Comments

Work Log

Change History

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Thomas E Enebo - 17/Mar/08 06:17 PM

Not enough time...bumping...

[ Permlink | « Hide ]

Vladimir Sizikov - 20/May/08 12:52 PM

Marcin is already working on it.

[ Permlink | « Hide ]

Marcin Mielzynski - 20/May/08 01:48 PM

The fixes pass now (r6744), there's still long truncation there though, we'll need to come up with a better handling later on.