EOF handling in case of reading program from standard input

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: JRuby 1.1b1
  • Fix Version/s: JRuby 1.2
  • Component/s: Parser
  • Labels:
    None
  • Environment:
    Mac OS X 10.4.11, Java 1.5.0_07, JRuby 1.1-SNAPSHOT
  • Patch Submitted:
    Yes

Description

JRuby does not handle EOF character in case of reading program from its standard input.
I have to hit Ctrl-D twice.

The problem is the EOF character is ignored by the lexer in some case, and next read operation will be blocking.

The posted patch adds a simple FilterInputStream subclass, EOFWrappedInputStream, which remembers previously happened EOF.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Thomas E Enebo added a comment -

When I run jruby:

./bin/jruby
^D

Things end with the first ^D. Could you provide more instructions for how to reproduce this?

Show
Thomas E Enebo added a comment - When I run jruby: 
./bin/jruby
^D
Things end with the first ^D. Could you provide more instructions for how to reproduce this?
Hide
Permalink
Takanori Ishikawa added a comment -

Sorry. How to reproduce this is:

% jruby
puts 1
^D

Just after a newline character is entered, the EOF character is ignored by the JRuby lexer.

in org.jruby.lexer.yacc.RubyYaccLexer#yylex (line:732)

case '\n':
  // Replace a string of newlines with a single one
  while((c = src.read()) == '\n');
  src.unread(c);
Show
Takanori Ishikawa added a comment - Sorry. How to reproduce this is: 
% jruby
puts 1
^D
Just after a newline character is entered, the EOF character is ignored by the JRuby lexer. in org.jruby.lexer.yacc.RubyYaccLexer#yylex (line:732) 
case '\n':
  // Replace a string of newlines with a single one
  while((c = src.read()) == '\n');
  src.unread(c);
Hide
Permalink
Charles Oliver Nutter added a comment -

Punting issues from 1.1 RC2 to 1.1 final.

Show
Charles Oliver Nutter added a comment - Punting issues from 1.1 RC2 to 1.1 final.
Hide
Permalink
Thomas E Enebo added a comment -

Bumping to point release in 1.1 series

Show
Thomas E Enebo added a comment - Bumping to point release in 1.1 series
Hide
Permalink
Charles Oliver Nutter added a comment -

Fixed in r8988.

Show
Charles Oliver Nutter added a comment - Fixed in r8988.

People

  • Assignee:
    Charles Oliver Nutter
    Reporter:
    Takanori Ishikawa
Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: