[#JRUBY-1807] Lots of spec failures for Time

JRuby

Created: 27/Dec/07 05:47 PM Updated: 23/Apr/08 10:03 AM

Component/s:

Core Classes/Modules

Affects Version/s:

JRuby 1.1+

Fix Version/s:

JRuby 1.1RC1

Time Tracking:

Not Specified

File Attachments:	1. time-failures.patch (3 kb)
Environment:	Latest JRuby 1.1b1

Testcase included:	yes
Patch Submitted:	Yes

Description

« Hide

Running rubinius specs against the latest JRuby leads to 19 failures out of 55. Not good.

For example:

ENV["TZ"]="CET-1:00:00"
puts Time.at(0).hour

Prints 1 in MRI, but 0 in JRuby.
And there are many more such failures.

The provided patch (one-liner) reduces the number of spec failures from 19 to 5 8-).

All

Comments

Work Log

Change History

Sort Order:

[ Permlink | « Hide ]

Committed in 5389. Thanks!

[ Permlink | « Hide ]

The given patch broke the "old" time specs we include in our repo, so I've reverted it.

[ Permlink | « Hide ]

HACK...Basically one tweak (someone please figure out why this works) so both old specs and new ones run

Fixed in commit 5412 on trunk

[ Permlink | « Hide ]

More elaborate version of Tom's patch, with extensive comments.

Some performance optimization will be done later, as part on another issue (we have an open issue for Time being slow).

[ Permlink | « Hide ]

This newer patch passes both, old and new, Time specs.

[ Permlink | « Hide ]

Additional fixes applied in 5418.