History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: JRUBY-1621
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Blocker Blocker
Assignee: Thomas E Enebo
Reporter: James Moore
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
JRuby

rss/maker doesn't compile

Created: 26/Nov/07 01:52 PM   Updated: 23/Apr/08 10:03 AM
Component/s: Core Classes/Modules
Affects Version/s: JRuby 1.1b1
Fix Version/s: JRuby 1.1RC1

Time Tracking:
Not Specified

Environment: trunk jruby, r5055


 Description  « Hide
rss/maker gets a syntax error, but works fine from MRI. (I'm not using it directly, but the rails tests include it.)

[james@ceantar ~]$ cat /tmp/r.rb
require 'rss/maker'

[james@ceantar ~]$ jruby /tmp/r.rb
/home/james/jruby/lib/ruby/1.8/rss/maker/base.rb:13:in `append_features': /home/james/jruby/lib/ruby/1.8/rss/maker/base.rb:19: syntax error, expecting '\n' ',' tRPAREN but found kEND instead (SyntaxError)

from /home/james/jruby/lib/ruby/1.8/rss/maker/base.rb:133:in `append_features'
from /home/james/jruby/lib/ruby/1.8/rss/maker/1.0.rb:3
from /home/james/jruby/lib/ruby/1.8/rss/maker/1.0.rb:3
from /home/james/jruby/lib/ruby/1.8/rss/maker/1.0.rb:3
from /home/james/jruby/lib/ruby/1.8/rss/maker/1.0.rb:3:in `require'
from /home/james/jruby/lib/ruby/1.8/rss/maker/1.0.rb:3:in `require'
from /home/james/jruby/lib/ruby/1.8/rss/maker.rb:30:in `require'
from /home/james/jruby/lib/ruby/1.8/rss/maker.rb:30:in `require'
from /tmp/r.rb:1:in `require'
from /tmp/r.rb:1:in `require'

[james@ceantar ~]$ ruby /tmp/r.rb
[james@ceantar ~]$

The .rb files in MRI and jruby are identical:
[james@ceantar jruby]$ diff /usr/lib/ruby/1.8/rss/maker/base.rb /home/james/jruby/lib/ruby/1.8/rss/maker/base.rb
[james@ceantar jruby]$



 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Thomas E Enebo - 26/Nov/07 03:06 PM
My last round of lexing changes broke this...I will fix for 1.1

Thomas E Enebo - 14/Dec/07 04:22 PM
Reduced testcase
eval <<-A
  eval <<-AB
  AB
A

Thomas E Enebo - 18/Dec/07 07:24 PM
I fixed me previous reduced test case, but then noticed a much more serious one:
eval(<<-A)
A

The additional () and any extra args breaks things. I imagine this could trip over many things (surprising we have only had one reported error on this.


Thomas E Enebo - 20/Dec/07 12:18 PM
Fixed in commit 5314 on trunk