JRuby

Extract into jruby.home from jar: url

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: JRuby 1.1.1
  • Fix Version/s: JRuby 1.1.2
  • Component/s: Miscellaneous
  • Labels:
    None
  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Description

Current jruby/extract.rb in trunk uses a regex on _FILE_ to determine the path to the jruby-complete.jar, and then opens it with java.util.zip.ZipFile, but this only works when jruby-complete.jar is run from a file: url, ie not when loaded over any sort of http connection. New method uses ClassLoader.getResource to determine the url of the JAR file, and then uses java.net.URL.openConnection.jar_file to open a JarFile descendant of ZipFile. It only copies jruby-complete.jar to jruby.home/lib if it was found at a file: url. Patch modifies trunk/jruby/src/jruby/extract.rb

Activity

Hide
Charles Oliver Nutter added a comment -

Patch provided, so this may be a trivial fix to get in for 1.1.2.

Show
Charles Oliver Nutter added a comment - Patch provided, so this may be a trivial fix to get in for 1.1.2.
Hide
Nick Sieger added a comment -

Applied in 6817. Thanks!

Show
Nick Sieger added a comment - Applied in 6817. Thanks!

People

Vote (1)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: