JRuby

Support Ruby's bigdecimal library

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: JRuby 0.9.0
  • Fix Version/s: JRuby 0.9.8
  • Component/s: Extensions
  • Labels:
    None
  • Number of attachments :
    2

Description

It appears that edge Rails now depends on the bigdecimal library, which we do not implement.

http://www.ruby-doc.org/stdlib/libdoc/bigdecimal/rdoc/index.html

In order to support edge Rails (and released Rails in the future, possibly starting with 1.2) we're going to need this library available. My hope is that it will be a simple matter of wrapping Java's built-in BigDecimal.

  1. Text File
    jruby-153.patch
    31/Dec/06 9:00 AM
    2 kB
    Miguel Covarrubias
  2. File
    testBigDecimal.rb
    31/Dec/06 9:00 AM
    0.8 kB
    Miguel Covarrubias

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jason Voegele added a comment -

Is there an existing test suite for Ruby's BigDecimal extension anywhere? I've searched but could not find one.

Show
Jason Voegele added a comment - Is there an existing test suite for Ruby's BigDecimal extension anywhere? I've searched but could not find one.
Hide
Permalink
Charles Oliver Nutter added a comment -

If there's not in either rubicon or in Ruby's source, then I don't know where else there'd be one. You might ask on ruby-core or ruby-talk mailing lists, but it's highly possible that there's no test suite out there.

Show
Charles Oliver Nutter added a comment - If there's not in either rubicon or in Ruby's source, then I don't know where else there'd be one. You might ask on ruby-core or ruby-talk mailing lists, but it's highly possible that there's no test suite out there.
Hide
Permalink
Charles Oliver Nutter added a comment -

I committed a partial implementation from Ola, but many of the methods are just stubbed out. There's more work to do, but non-bigdecimal Rails 1.2 tests will run now.

Show
Charles Oliver Nutter added a comment - I committed a partial implementation from Ola, but many of the methods are just stubbed out. There's more work to do, but non-bigdecimal Rails 1.2 tests will run now.
Hide
Permalink
Steven Parkes added a comment -

The current bigdecimal doesn't provide a global function, i.e., BigDecimal(string): #new has to be explicit. However, bigdecimal/util.rb uses the non-new syntax.

Used by AR for decimal type columns.

Show
Steven Parkes added a comment - The current bigdecimal doesn't provide a global function, i.e., BigDecimal(string): #new has to be explicit. However, bigdecimal/util.rb uses the non-new syntax. Used by AR for decimal type columns.
Hide
Permalink
Steven Parkes added a comment -

And doesn't compare well to floats. I tried looking into this but got stuck: haven't been able to figure out how jruby implements this kind of comparison. Doesn't call <=>? Doesn't seem to or I'm missing something.

I wonder if the incomplete functions in BD should raise something rather than return bad data? It'd save time to get a definite idea rather than trying to track down latent wrong results?

Show
Steven Parkes added a comment - And doesn't compare well to floats. I tried looking into this but got stuck: haven't been able to figure out how jruby implements this kind of comparison. Doesn't call <=>? Doesn't seem to or I'm missing something. I wonder if the incomplete functions in BD should raise something rather than return bad data? It'd save time to get a definite idea rather than trying to track down latent wrong results?
Hide
Permalink
Miguel Covarrubias added a comment -

It looks like the non-explicit new is now supported, although like the explicit new, it's more permissive than its MRI equivalent: not only are strings accepted, but so are Fixnums, Floats, other BigDecimals, and possibly other types. In both the explicit and implicit constructions, MRI seems to want to #to_str the argument, and if it can't it raises a TypeError. I'm not sure why MRI is so persnickety in this regard, but it is consistent with the bigdecimal documentation.

Show
Miguel Covarrubias added a comment - It looks like the non-explicit new is now supported, although like the explicit new, it's more permissive than its MRI equivalent: not only are strings accepted, but so are Fixnums, Floats, other BigDecimals, and possibly other types. In both the explicit and implicit constructions, MRI seems to want to #to_str the argument, and if it can't it raises a TypeError. I'm not sure why MRI is so persnickety in this regard, but it is consistent with the bigdecimal documentation.
Hide
Permalink
Miguel Covarrubias added a comment -

Attached are some patches to make JRuby's BigDecimal reject first arguments not responding to #to_str, as well as tests for the some of the problems documented in this case.

JRUBY-341 documents BigDecimal's problems with integers, and here we have mention of problems with floats. If those two issues are related, might the float issue be folded into JRUBY-341 and this issue closed?

Show
Miguel Covarrubias added a comment - Attached are some patches to make JRuby's BigDecimal reject first arguments not responding to #to_str, as well as tests for the some of the problems documented in this case. JRUBY-341 documents BigDecimal's problems with integers, and here we have mention of problems with floats. If those two issues are related, might the float issue be folded into JRUBY-341 and this issue closed?

People

  • Assignee:
    Ola Bini
    Reporter:
    Charles Oliver Nutter
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: