[#JRUBY-1508] Dir#[] and Dir#glob incompatibilities

JRuby

Dir#[] and Dir#glob incompatibilities

Created: 02/Nov/07 03:43 PM Updated: 23/Apr/08 10:03 AM

Component/s:

Core Classes/Modules

Affects Version/s:

JRuby 1.1b1, JRuby 1.0.2

Fix Version/s:

JRuby 1.1RC1

Time Tracking:

Not Specified

File Attachments:

rubydir.patch (3 kb)

Description

« Hide

See http://www.ruby-doc.org/core/classes/Dir.html#M002348

Dir#[] is currently mapped directly onto Dir#glob, except our glob only accepts one pattern. According to the docs for glob, it should accept either an array or a string.

In addition to this:
Dir#[] cannot accept an array
Dir#[] cannot accept a block (though actually syntax already protects us)

All

Comments

Work Log

Change History

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Daniel Machera - 03/Jan/08 08:26 PM

My first jruby patch, be gentle.

[ Permlink | « Hide ]

Thomas E Enebo - 03/Jan/08 09:56 PM

I applied Daniels patch on commit 5488 on trunk. I also did a bunch of extra checks when I noticed that glob and [] have slightly different syntaxes. Leaving open for 1.0.

[ Permlink | « Hide ]

Thomas E Enebo - 04/Jan/08 04:09 PM

bah...let someone reopen for 1.0 if someone is missing this functionality.