JRuby

Compare uses of $VERBOSE with MRI

Details

  • Number of attachments :
    0

Description

We recently noticed different handling of $VERBOSE for #warn that was fixed in 4744, due to a misunderstanding of the meaning. $VERBOSE can apparently take true, false, or nil values, and they all mean slightly different things. Checking uses of $VERBOSE in the code base should be done to ensure we're doing the same thing as MRI.

Activity

Hide
Nick Sieger added a comment -

Actually, what this comes down to is making sure we call #warn vs. #warning in the right places.

Show
Nick Sieger added a comment - Actually, what this comes down to is making sure we call #warn vs. #warning in the right places.
Hide
Charles Oliver Nutter added a comment -

I'm sure we have lots of places where we use warn and warning incorrectly. We should rename those suckers to represent what they actually do:

warnNormal
warnVerbose

or

warn
warnWhenVerbose

or something like that. I know I'm going to forget which is which again.

Show
Charles Oliver Nutter added a comment - I'm sure we have lots of places where we use warn and warning incorrectly. We should rename those suckers to represent what they actually do: warnNormal warnVerbose or warn warnWhenVerbose or something like that. I know I'm going to forget which is which again.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: