[#JRUBY-1469] RaiseException emits a return event not a raise event

JRuby

RaiseException emits a return event not a raise event

Created: 24/Oct/07 07:52 AM Updated: 16/Jan/08 08:24 AM

Component/s:

Core Classes/Modules

Affects Version/s:

None

Fix Version/s:

JRuby 1.0.4

Time Tracking:

Not Specified

File Attachments:

jruby-1469-test-patch.diff (0.8 kb)
2.

raise.patch (0.6 kb)
3.

test_trace_func.patch (3 kb)

Patch Submitted:

Yes

Description

« Hide

RaiseException should emit RUBY_EVENT_RAISE not RUBY_EVENT_RETURN. One line patch attached.

This causes jruby-debug to incorrectly unwind the entire stack when stepping due to unbalanced calls and returns.

All

Comments

Work Log

Change History

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Charles Oliver Nutter - 24/Oct/07 06:47 PM

Applied on trunk and 1.0 branches...can you provide a test case for this?

[ Permlink | « Hide ]

Charles Oliver Nutter - 24/Oct/07 06:49 PM

Scheduling for 1.0.2 and 1.1; awaiting a test case.

[ Permlink | « Hide ]

Martin Krauskopf - 25/Oct/07 03:30 AM

Attaching test case. But test_trace_func is (probably temporarily) disable in test/jruby_index. I've tried the test with enabling it in jruby_index and uncommenting failing test cases in the file.
The attached regression test case proceed after Peter's path - not before.

[ Permlink | « Hide ]

Charles Oliver Nutter - 25/Oct/07 04:00 PM

After applying the given diff, the test case doesn't even pass in MRI. But I also noticed just now that c-call traces are completely gone on trunc because of the new generated method bindings; I'm going to file a separate bug for that.

[ Permlink | « Hide ]

Charles Oliver Nutter - 30/Oct/07 02:57 AM

Bumping off 1.0.2.

[ Permlink | « Hide ]

Peter Brant - 30/Oct/07 08:49 PM

Patch to update Martin's test case to the latest trunk (with JRUBY-1475 applied). It also replaces a hardcoded path with #{_FILE_} in another test case.

[ Permlink | « Hide ]

Ola Bini - 16/Jan/08 08:24 AM

This doesn't really work on JRuby-1.0 branch. (It's the test case that doesn't apply good)