JRuby

Unknown problem with ZLib::Inflate

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: JRuby 1.x+
  • Fix Version/s: JRuby 1.1.5
  • Component/s: Core Classes/Modules
  • Labels:
    None
  • Environment:
    java 1.5.0_07 (Apple Computer, Inc.)
    macos 10.4.10
  • Testcase included:
    yes
  • Number of attachments :
    2

Description

The rubyzip ZipFileExtract.test_extract test fails with a stack trace on JRuby 1.0.1 and trunk (oct12, 2007).

The Exception is:
Exception in thread "main" java.util.zip.DataFormatException: unknown compression method

The compression method should be:
compression method is ZipEntry::DEFLATED

To reproduce:
Zlib::Inflate.inflate(File.new('rubyzip-test_extract-data').read)

Full rubyzip test output and trace:

in test_extract before ZipFile.open(5entry_copy.zip)
before zf.extract(data/generated/longBinary.bin, extEntry)
in ZipInputStream.open_entry, before ZipEntry.read_local_entry
compression method is ZipEntry::DEFLATED
in Zip::Inflater.initialize
inputStream class: File
inputStream: #<File:5entry_copy.zip>
in ZipInputStream.sysread
numberOfBytes = 32768
buf = ""
buf class = String
decompressor class = Zip::Inflater
before Zip::Inflater.sysread(numberOfBytes, buf)
in Inflater.sysread
before while loop
before internal_produce_input(buf)
@zlibInflater class: Zlib::Inflate
@zlibInflater: #<Zlib::Inflate:0x68632b>
@inputStream class: File
@inputStream: #<File:5entry_copy.zip>
buf class: String
Decompressor::CHUNK_SIZE -> 32768
before data = @inputStream.read(Decompressor::CHUNK_SIZE, buf)
writing the contents of data to file 'rubyzip-test_extract-data'
before @zlibInflater.inflate(data)
Exception in thread "main" java.util.zip.DataFormatException: unknown compression method
at java.util.zip.Inflater.inflateBytes(Native Method)
at java.util.zip.Inflater.inflate(Inflater.java:215)
at java.util.zip.Inflater.inflate(Inflater.java:232)
at org.jruby.util.ZlibInflate.inflate(ZlibInflate.java:95)
at org.jruby.RubyZlib$Inflate.inflate(RubyZlib.java:402)
at org.jruby.RubyZlib$InflateInvoker$inflate_method_1_0.call(Unknown Source)
at org.jruby.runtime.CallAdapter$DefaultCallAdapter.call(CallAdapter.java:154)
at org.jruby.runtime.CallAdapter$DefaultCallAdapter.call(CallAdapter.java:107)
at org.jruby.evaluator.ASTInterpreter.callNode(ASTInterpreter.java:561)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:208)
at org.jruby.evaluator.ASTInterpreter.blockNode(ASTInterpreter.java:535)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:202)
at org.jruby.evaluator.ASTInterpreter.rescueNode(ASTInterpreter.java:1412)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:351)
at org.jruby.evaluator.ASTInterpreter.blockNode(ASTInterpreter.java:535)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:202)
at org.jruby.evaluator.ASTInterpreter.eval(ASTInterpreter.java:165)
at org.jruby.internal.runtime.methods.DefaultMethod.call(DefaultMethod.java:144)
at org.jruby.runtime.CallAdapter$DefaultCallAdapter.call(CallAdapter.java:140)
at org.jruby.runtime.CallAdapter$DefaultCallAdapter.call(CallAdapter.java:107)
at org.jruby.evaluator.ASTInterpreter.fCallNode(ASTInterpreter.java:996)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:254)
at org.jruby.evaluator.ASTInterpreter.setupArgs(ASTInterpreter.java:2050)
at org.jruby.evaluator.ASTInterpreter.callNode(ASTInterpreter.java:553)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:208)
at org.jruby.evaluator.ASTInterpreter.blockNode(ASTInterpreter.java:535)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:202)
at org.jruby.evaluator.ASTInterpreter.whileNode(ASTInterpreter.java:1656)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:388)
at org.jruby.evaluator.ASTInterpreter.blockNode(ASTInterpreter.java:535)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:202)
at org.jruby.evaluator.ASTInterpreter.eval(ASTInterpreter.java:165)
at org.jruby.internal.runtime.methods.DefaultMethod.call(DefaultMethod.java:144)
at org.jruby.runtime.CallAdapter$DefaultCallAdapter.call(CallAdapter.java:154)
at org.jruby.runtime.CallAdapter$DefaultCallAdapter.call(CallAdapter.java:107)
at org.jruby.evaluator.ASTInterpreter.callNode(ASTInterpreter.java:561)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:208)
at org.jruby.evaluator.ASTInterpreter.blockNode(ASTInterpreter.java:535)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:202)
at org.jruby.evaluator.ASTInterpreter.eval(ASTInterpreter.java:165)
at org.jruby.internal.runtime.methods.DefaultMethod.call(DefaultMethod.java:144)
at org.jruby.runtime.CallAdapter$DefaultCallAdapter.call(CallAdapter.java:154)
at org.jruby.runtime.CallAdapter$DefaultCallAdapter.call(CallAdapter.java:107)
at org.jruby.evaluator.ASTInterpreter.callNode(ASTInterpreter.java:561)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:208)
at org.jruby.evaluator.ASTInterpreter.dAsgnNode(ASTInterpreter.java:759)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:228)
at org.jruby.evaluator.ASTInterpreter.whileNode(ASTInterpreter.java:1652)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:388)
at org.jruby.evaluator.ASTInterpreter.blockNode(ASTInterpreter.java:535)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:202)
at org.jruby.evaluator.ASTInterpreter.eval(ASTInterpreter.java:165)
at org.jruby.runtime.Block.yield(Block.java:235)
at org.jruby.evaluator.ASTInterpreter.yieldNode(ASTInterpreter.java:1712)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:392)
at org.jruby.evaluator.ASTInterpreter.returnNode(ASTInterpreter.java:1484)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:355)
at org.jruby.evaluator.ASTInterpreter.ensureNode(ASTInterpreter.java:968)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:248)
at org.jruby.evaluator.ASTInterpreter.blockNode(ASTInterpreter.java:535)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:202)
at org.jruby.evaluator.ASTInterpreter.eval(ASTInterpreter.java:165)
at org.jruby.internal.runtime.methods.DefaultMethod.call(DefaultMethod.java:144)
at org.jruby.runtime.CallAdapter$DefaultCallAdapter.call(CallAdapter.java:154)
at org.jruby.evaluator.ASTInterpreter.fCallNode(ASTInterpreter.java:1001)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:254)
at org.jruby.evaluator.ASTInterpreter.eval(ASTInterpreter.java:165)
at org.jruby.runtime.Block.yield(Block.java:235)
at org.jruby.runtime.Block.yield(Block.java:200)
at org.jruby.RubyFile.open(RubyFile.java:898)
at org.jruby.RubyFile.open(RubyFile.java:871)
at org.jruby.RubyFileInvoker$open_method_1_0.call(Unknown Source)
at org.jruby.runtime.CallAdapter$DefaultCallAdapter.call(CallAdapter.java:154)
at org.jruby.evaluator.ASTInterpreter.callNode(ASTInterpreter.java:566)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:208)
at org.jruby.evaluator.ASTInterpreter.blockNode(ASTInterpreter.java:535)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:202)
at org.jruby.evaluator.ASTInterpreter.eval(ASTInterpreter.java:165)
at org.jruby.internal.runtime.methods.DefaultMethod.call(DefaultMethod.java:144)
at org.jruby.runtime.CallAdapter$DefaultCallAdapter.call(CallAdapter.java:154)
at org.jruby.evaluator.ASTInterpreter.fCallNode(ASTInterpreter.java:1001)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:254)
at org.jruby.evaluator.ASTInterpreter.blockNode(ASTInterpreter.java:535)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:202)
at org.jruby.evaluator.ASTInterpreter.eval(ASTInterpreter.java:165)
at org.jruby.internal.runtime.methods.DefaultMethod.call(DefaultMethod.java:144)
at org.jruby.runtime.CallAdapter$DefaultCallAdapter.call(CallAdapter.java:140)
at org.jruby.evaluator.ASTInterpreter.callNode(ASTInterpreter.java:566)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:208)
at org.jruby.evaluator.ASTInterpreter.blockNode(ASTInterpreter.java:535)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:202)
at org.jruby.evaluator.ASTInterpreter.eval(ASTInterpreter.java:165)
at org.jruby.internal.runtime.methods.DefaultMethod.call(DefaultMethod.java:144)
at org.jruby.runtime.CallAdapter$DefaultCallAdapter.call(CallAdapter.java:154)
at org.jruby.runtime.CallAdapter$DefaultCallAdapter.call(CallAdapter.java:107)
at ziptest.closure101(ziptest.rb:1396)
at ziptestBlockclosure101xx1.call(Unknown Source)
at org.jruby.runtime.CompiledBlock.yield(CompiledBlock.java:100)
at org.jruby.evaluator.ASTInterpreter.yieldNode(ASTInterpreter.java:1712)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:392)
at org.jruby.evaluator.ASTInterpreter.ensureNode(ASTInterpreter.java:968)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:248)
at org.jruby.evaluator.ASTInterpreter.blockNode(ASTInterpreter.java:535)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:202)
at org.jruby.evaluator.ASTInterpreter.eval(ASTInterpreter.java:165)
at org.jruby.internal.runtime.methods.DefaultMethod.call(DefaultMethod.java:144)
at org.jruby.runtime.CallAdapter$DefaultCallAdapter.call(CallAdapter.java:154)
at ziptest.test_extract__124(ziptest.rb:1393)
at ziptestInvokertest_extract__124Fixed0.call(Unknown Source)
at org.jruby.RubyObject.send(RubyObject.java:1414)
at org.jruby.RubyObjectInvoker$send_method_1_0.call(Unknown Source)
at org.jruby.runtime.CallAdapter$DefaultCallAdapter.call(CallAdapter.java:154)
at org.jruby.runtime.CallAdapter$DefaultCallAdapter.call(CallAdapter.java:107)
at run3968502_9725752.__rescue_1(/Users/travis/jruby-1.1/lib/ruby/1.8/test/unit/testcase.rb:72)
at run3968502_9725752.__ensure_1(/Users/travis/jruby-1.1/lib/ruby/1.8/test/unit/testcase.rb:71)
at run3968502_9725752._file_(/Users/travis/jruby-1.1/lib/ruby/1.8/test/unit/testcase.rb:71)
at run3968502_9725752.run(/Users/travis/jruby-1.1/lib/ruby/1.8/test/unit/testcase.rb)
at org.jruby.internal.runtime.methods.DefaultMethod.call(DefaultMethod.java:112)
at org.jruby.runtime.CallAdapter$DefaultCallAdapter.call(CallAdapter.java:154)
at org.jruby.evaluator.ASTInterpreter.callNode(ASTInterpreter.java:566)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:208)
at org.jruby.evaluator.ASTInterpreter.eval(ASTInterpreter.java:165)
at org.jruby.runtime.Block.yield(Block.java:235)
at org.jruby.runtime.Block.yield(Block.java:200)
at org.jruby.RubyArray.each(RubyArray.java:1172)
at org.jruby.RubyArrayInvoker$each_method_0_0.call(Unknown Source)
at org.jruby.runtime.CallAdapter$DefaultCallAdapter.call(CallAdapter.java:140)
at org.jruby.evaluator.ASTInterpreter.callNode(ASTInterpreter.java:566)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:208)
at org.jruby.evaluator.ASTInterpreter.blockNode(ASTInterpreter.java:535)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:202)
at org.jruby.evaluator.ASTInterpreter.eval(ASTInterpreter.java:165)
at org.jruby.internal.runtime.methods.DefaultMethod.call(DefaultMethod.java:144)
at org.jruby.runtime.CallAdapter$DefaultCallAdapter.call(CallAdapter.java:154)
at org.jruby.evaluator.ASTInterpreter.callNode(ASTInterpreter.java:566)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:208)
at org.jruby.evaluator.ASTInterpreter.eval(ASTInterpreter.java:165)
at org.jruby.runtime.Block.yield(Block.java:235)
at org.jruby.runtime.Block.yield(Block.java:200)
at org.jruby.RubyArray.each(RubyArray.java:1172)
at org.jruby.RubyArrayInvoker$each_method_0_0.call(Unknown Source)
at org.jruby.runtime.CallAdapter$DefaultCallAdapter.call(CallAdapter.java:154)
at org.jruby.evaluator.ASTInterpreter.callNode(ASTInterpreter.java:566)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:208)
at org.jruby.evaluator.ASTInterpreter.blockNode(ASTInterpreter.java:535)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:202)
at org.jruby.evaluator.ASTInterpreter.eval(ASTInterpreter.java:165)
at org.jruby.internal.runtime.methods.DefaultMethod.call(DefaultMethod.java:144)
at org.jruby.runtime.CallAdapter$DefaultCallAdapter.call(CallAdapter.java:154)
at org.jruby.evaluator.ASTInterpreter.callNode(ASTInterpreter.java:566)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:208)
at org.jruby.evaluator.ASTInterpreter.blockNode(ASTInterpreter.java:535)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:202)
at org.jruby.evaluator.ASTInterpreter.eval(ASTInterpreter.java:165)
at org.jruby.internal.runtime.methods.DefaultMethod.call(DefaultMethod.java:144)
at org.jruby.runtime.CallAdapter$DefaultCallAdapter.call(CallAdapter.java:154)
at org.jruby.runtime.CallAdapter$DefaultCallAdapter.call(CallAdapter.java:107)
at org.jruby.evaluator.ASTInterpreter.callNode(ASTInterpreter.java:561)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:208)
at org.jruby.evaluator.ASTInterpreter.returnNode(ASTInterpreter.java:1484)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:355)
at org.jruby.evaluator.ASTInterpreter.eval(ASTInterpreter.java:165)
at org.jruby.internal.runtime.methods.DefaultMethod.call(DefaultMethod.java:144)
at org.jruby.runtime.CallAdapter$DefaultCallAdapter.call(CallAdapter.java:154)
at org.jruby.runtime.CallAdapter$DefaultCallAdapter.call(CallAdapter.java:80)
at org.jruby.evaluator.ASTInterpreter.vcallNode(ASTInterpreter.java:1643)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:383)
at org.jruby.evaluator.ASTInterpreter.returnNode(ASTInterpreter.java:1484)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:355)
at org.jruby.evaluator.ASTInterpreter.blockNode(ASTInterpreter.java:535)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:202)
at org.jruby.evaluator.ASTInterpreter.eval(ASTInterpreter.java:165)
at org.jruby.internal.runtime.methods.DefaultMethod.call(DefaultMethod.java:144)
at org.jruby.runtime.CallAdapter$DefaultCallAdapter.call(CallAdapter.java:154)
at org.jruby.runtime.CallAdapter$DefaultCallAdapter.call(CallAdapter.java:107)
at org.jruby.evaluator.ASTInterpreter.callNode(ASTInterpreter.java:561)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:208)
at org.jruby.evaluator.ASTInterpreter.returnNode(ASTInterpreter.java:1484)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:355)
at org.jruby.evaluator.ASTInterpreter.eval(ASTInterpreter.java:165)
at org.jruby.internal.runtime.methods.DefaultMethod.call(DefaultMethod.java:144)
at org.jruby.runtime.CallAdapter$DefaultCallAdapter.call(CallAdapter.java:154)
at org.jruby.runtime.CallAdapter$DefaultCallAdapter.call(CallAdapter.java:107)
at org.jruby.evaluator.ASTInterpreter.callNode(ASTInterpreter.java:561)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:208)
at org.jruby.evaluator.ASTInterpreter.callNode(ASTInterpreter.java:552)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:208)
at org.jruby.evaluator.ASTInterpreter.blockNode(ASTInterpreter.java:535)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:202)
at org.jruby.evaluator.ASTInterpreter.eval(ASTInterpreter.java:165)
at org.jruby.internal.runtime.methods.DefaultMethod.call(DefaultMethod.java:144)
at org.jruby.runtime.CallAdapter$DefaultCallAdapter.call(CallAdapter.java:154)
at org.jruby.runtime.CallAdapter$DefaultCallAdapter.call(CallAdapter.java:107)
at org.jruby.evaluator.ASTInterpreter.callNode(ASTInterpreter.java:561)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:208)
at org.jruby.evaluator.ASTInterpreter.blockNode(ASTInterpreter.java:535)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:202)
at org.jruby.evaluator.ASTInterpreter.eval(ASTInterpreter.java:165)
at org.jruby.internal.runtime.methods.DefaultMethod.call(DefaultMethod.java:144)
at org.jruby.runtime.CallAdapter$DefaultCallAdapter.call(CallAdapter.java:154)
at org.jruby.runtime.CallAdapter$DefaultCallAdapter.call(CallAdapter.java:107)
at org.jruby.evaluator.ASTInterpreter.callNode(ASTInterpreter.java:561)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:208)
at org.jruby.evaluator.ASTInterpreter.setupArgs(ASTInterpreter.java:2050)
at org.jruby.evaluator.ASTInterpreter.fCallNode(ASTInterpreter.java:991)
at org.jruby.evaluator.ASTInterpreter.evalInternal(ASTInterpreter.java:254)
at org.jruby.evaluator.ASTInterpreter.eval(ASTInterpreter.java:165)
at org.jruby.runtime.Block.yield(Block.java:235)
at org.jruby.runtime.Block.call(Block.java:188)
at org.jruby.RubyProc.call(RubyProc.java:197)
at org.jruby.RubyProc.call(RubyProc.java:171)
at org.jruby.Ruby.tearDown(Ruby.java:1882)
at org.jruby.Main.runInterpreter(Main.java:225)
at org.jruby.Main.runInterpreter(Main.java:179)
at org.jruby.Main.run(Main.java:121)
at org.jruby.Main.main(Main.java:96)

  1. Text File
    JRUBY-1424.patch
    15/Oct/07 4:43 AM
    1 kB
    Travis Tilley
  2. File
    rubyzip-test_extract-data
    12/Oct/07 1:35 AM
    28 kB
    Travis Tilley

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Travis Tilley added a comment -

for the sake of completeness, here are the numbers for the rubyzip test suite. other than the one exception, most of the other failures are TypeError: can't convert nil into String.

ruby 1.8.5 (2007-10-12 rev 4201) [i386-jruby1.0.1]
86 tests, 259 assertions, 1 failures, 25 errors

ruby 1.8.5 (2007-10-12 rev 3876) [i386-jruby1.1]
the exception exits Test::Unit completely before reporting

also, trunk doesn't seem to like long options anymore:
-e:1:in `method_missing': undefined local variable or method `rsion' for main:Object (NameError)

Show
Travis Tilley added a comment - for the sake of completeness, here are the numbers for the rubyzip test suite. other than the one exception, most of the other failures are TypeError: can't convert nil into String. ruby 1.8.5 (2007-10-12 rev 4201) [i386-jruby1.0.1] 86 tests, 259 assertions, 1 failures, 25 errors ruby 1.8.5 (2007-10-12 rev 3876) [i386-jruby1.1] the exception exits Test::Unit completely before reporting also, trunk doesn't seem to like long options anymore: -e:1:in `method_missing': undefined local variable or method `rsion' for main:Object (NameError)
Hide
Permalink
Travis Tilley added a comment -

catch exception, set nowrap to true, retry

Show
Travis Tilley added a comment - catch exception, set nowrap to true, retry
Hide
Permalink
Travis Tilley added a comment -

With the above patch this bug goes from throwing an exception to a TypeError.

ZipFile.open('5entry_copy.zip')

{|zf| zf.extract('data/generated/longBinary.bin', 'extEntry') }

TypeError: can't convert NilClass into nil
from /Users/travis/gems/1.8/gems/rubyzip-0.9.1/test/../lib/zip/zip.rb:186:in `sysread'
from /Users/travis/gems/1.8/gems/rubyzip-0.9.1/test/../lib/zip/zip.rb:128:in `sysread'
from /Users/travis/gems/1.8/gems/rubyzip-0.9.1/test/../lib/zip/zip.rb:841:in `write_file'
from /Users/travis/gems/1.8/gems/rubyzip-0.9.1/test/../lib/zip/zip.rb:466:in `get_input_stream'
from /Users/travis/gems/1.8/gems/rubyzip-0.9.1/test/../lib/zip/zip.rb:836:in `write_file'
from /Users/travis/gems/1.8/gems/rubyzip-0.9.1/test/../lib/zip/zip.rb:466:in `open'
from /Users/travis/gems/1.8/gems/rubyzip-0.9.1/test/../lib/zip/zip.rb:835:in `write_file'
from /Users/travis/gems/1.8/gems/rubyzip-0.9.1/test/../lib/zip/zip.rb:466:in `extract'
from /Users/travis/gems/1.8/gems/rubyzip-0.9.1/test/../lib/zip/zip.rb:1470:in `extract'
from (irb):7:in `binding'

Show
Travis Tilley added a comment - With the above patch this bug goes from throwing an exception to a TypeError. ZipFile.open('5entry_copy.zip') {|zf| zf.extract('data/generated/longBinary.bin', 'extEntry') } TypeError: can't convert NilClass into nil from /Users/travis/gems/1.8/gems/rubyzip-0.9.1/test/../lib/zip/zip.rb:186:in `sysread' from /Users/travis/gems/1.8/gems/rubyzip-0.9.1/test/../lib/zip/zip.rb:128:in `sysread' from /Users/travis/gems/1.8/gems/rubyzip-0.9.1/test/../lib/zip/zip.rb:841:in `write_file' from /Users/travis/gems/1.8/gems/rubyzip-0.9.1/test/../lib/zip/zip.rb:466:in `get_input_stream' from /Users/travis/gems/1.8/gems/rubyzip-0.9.1/test/../lib/zip/zip.rb:836:in `write_file' from /Users/travis/gems/1.8/gems/rubyzip-0.9.1/test/../lib/zip/zip.rb:466:in `open' from /Users/travis/gems/1.8/gems/rubyzip-0.9.1/test/../lib/zip/zip.rb:835:in `write_file' from /Users/travis/gems/1.8/gems/rubyzip-0.9.1/test/../lib/zip/zip.rb:466:in `extract' from /Users/travis/gems/1.8/gems/rubyzip-0.9.1/test/../lib/zip/zip.rb:1470:in `extract' from (irb):7:in `binding'
Hide
Permalink
Travis Tilley added a comment -

just to clarify: this is, in fact, the fix for this bug. the nil problems were the result of File::Stat.uid not existing.

Show
Travis Tilley added a comment - just to clarify: this is, in fact, the fix for this bug. the nil problems were the result of File::Stat.uid not existing.
Hide
Permalink
Charles Oliver Nutter added a comment -

Travis, did you ever determine how MRI or zlib figures this out? If they have a better way of making this determination, we would want to go with that rather than this fallback mechanism.

Show
Charles Oliver Nutter added a comment - Travis, did you ever determine how MRI or zlib figures this out? If they have a better way of making this determination, we would want to go with that rather than this fallback mechanism.
Hide
Permalink
Travis Tilley added a comment -

Thank you for reminding me to comment on this bug, I had gotten distracted with other things.
I cannot, for the life of me, decipher how the c version does it. C escapes me... and reading it makes me sad.

Show
Travis Tilley added a comment - Thank you for reminding me to comment on this bug, I had gotten distracted with other things. I cannot, for the life of me, decipher how the c version does it. C escapes me... and reading it makes me sad.
Hide
Permalink
Travis Tilley added a comment -

there's a comment relating to gzip support:

/* NOTE: Features for gzip files of Ruby/zlib are written from scratch

  • and using undocumented feature of zlib, negative wbits.
  • I don't think gzFile APIs of zlib are good for Ruby.
    */
Show
Travis Tilley added a comment - there's a comment relating to gzip support: /* NOTE: Features for gzip files of Ruby/zlib are written from scratch and using undocumented feature of zlib, negative wbits. I don't think gzFile APIs of zlib are good for Ruby. */
Hide
Permalink
Travis Tilley added a comment -

[03:49] sanxiyn Reading the log, someone mentioned zlib's negative bit width...
[03:52] sanxiyn Since Python uses the same feature, I know what it is.
[03:54] sanxiyn zlib has API inflateInit2(z_stream stream, int windowBits). If you pass negative integer, zlib doesn't try to process zlib/gzip header.
[03:55] sanxiyn (For details just search for inflateInit2 in zlib.h.)
[04:02] sanxiyn I'm not sure what's the context though.
[04:05] sanxiyn From looking at JDK documentation, "nowrap" boolean parameter to Inflater constructor seems to correspond to negative wbits.
[04:05] sanxiyn http://java.sun.com/javase/6/docs/api/java/util/zip/Inflater.html#Inflater(boolean)

Show
Travis Tilley added a comment - [03:49] sanxiyn Reading the log, someone mentioned zlib's negative bit width... [03:52] sanxiyn Since Python uses the same feature, I know what it is. [03:54] sanxiyn zlib has API inflateInit2(z_stream stream, int windowBits). If you pass negative integer, zlib doesn't try to process zlib/gzip header. [03:55] sanxiyn (For details just search for inflateInit2 in zlib.h.) [04:02] sanxiyn I'm not sure what's the context though. [04:05] sanxiyn From looking at JDK documentation, "nowrap" boolean parameter to Inflater constructor seems to correspond to negative wbits. [04:05] sanxiyn http://java.sun.com/javase/6/docs/api/java/util/zip/Inflater.html#Inflater(boolean )
Hide
Permalink
Charles Oliver Nutter added a comment -

So where do we stand on this...is there a way to tell ahead of time which format we should use?

Show
Charles Oliver Nutter added a comment - So where do we stand on this...is there a way to tell ahead of time which format we should use?
Hide
Permalink
Charles Oliver Nutter added a comment -

I've applied this temporary fix, but it seems like we should be able to tell in advance, rather than failover like this. Bumping that work to 1.0.3.

Show
Charles Oliver Nutter added a comment - I've applied this temporary fix, but it seems like we should be able to tell in advance, rather than failover like this. Bumping that work to 1.0.3.
Hide
Permalink
Charles Oliver Nutter added a comment -

Check whether this still affects 1.1 branch. 1.0 branch is dead

Show
Charles Oliver Nutter added a comment - Check whether this still affects 1.1 branch. 1.0 branch is dead
Hide
Permalink
Charles Oliver Nutter added a comment -

Screw it...I fiddled with it for another 20 minutes and still couldn't figure out how we're supposed to guess ahead of time to set nowrap. The DataFormatException fallback isn't the greatest, but it works. Resolved. Good riddance.

Show
Charles Oliver Nutter added a comment - Screw it...I fiddled with it for another 20 minutes and still couldn't figure out how we're supposed to guess ahead of time to set nowrap. The DataFormatException fallback isn't the greatest, but it works. Resolved. Good riddance.
Hide
Permalink
Vladimir Sizikov added a comment -

Trying to fix the exception, catching it and retrying is actually wrong. MRI does not do that as well, and will fail the example, listed at the top:

/opt/ruby19-dev/bin/irb -rzlib
irb(main):001:0> Zlib::Inflate.inflate(File.new('rubyzip-test_extract-data').read)
Zlib::DataError: incorrect header check
        from (irb):1:in `inflate'
        from (irb):1
        from /opt/ruby19-dev/bin/irb:12:in `<main>'

By catching and retrying we are actually hiding some other errors too.

In order to inflate the data without the headers on needs to use the specially constructed inflater:

inflater = Zlib::Inflate.new(-Zlib::MAX_WBITS)

Then it will work as expected.

In short, I'm going to adjust our Zlib::Inflate to behave exactly like MRI one, which means in this particular case we'll raise an exception.

Show
Vladimir Sizikov added a comment - Trying to fix the exception, catching it and retrying is actually wrong. MRI does not do that as well, and will fail the example, listed at the top: /opt/ruby19-dev/bin/irb -rzlib irb(main):001:0> Zlib::Inflate.inflate(File. new ('rubyzip-test_extract-data').read) Zlib::DataError: incorrect header check from (irb):1:in `inflate' from (irb):1 from /opt/ruby19-dev/bin/irb:12:in `<main>' By catching and retrying we are actually hiding some other errors too. In order to inflate the data without the headers on needs to use the specially constructed inflater: inflater = Zlib::Inflate.new(-Zlib::MAX_WBITS) Then it will work as expected. In short, I'm going to adjust our Zlib::Inflate to behave exactly like MRI one, which means in this particular case we'll raise an exception.

People

  • Assignee:
    Charles Oliver Nutter
    Reporter:
    Travis Tilley
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: