Issue Details (XML | Word | Printable)

Key: JRUBY-1229
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Charles Oliver Nutter
Reporter: Cliff Moon
Votes: 1
Watchers: 2
Operations

If you were logged in you would be able to see more operations.
JRuby

require throws a LoadError when Jar has a null Manifest

Created: 20/Jul/07 09:27 AM   Updated: 22/Dec/07 06:28 AM
Component/s: Core Classes/Modules
Affects Version/s: JRuby 1.0.0
Fix Version/s: JRuby 1.0.2, JRuby 1.1b1

Time Tracking:
Not Specified

File Attachments: 1. Java Archive File aspectjrt-1.5.2.jar (112 kB)
2. Text File null_manifest.patch (2 kB)
3. File test.rb (0.3 kB)

Environment: Mac OS X, jirb

Testcase included: yes
Patch Submitted: Yes


 Description  « Hide
Require throws a LoadError when trying to load aspectjrt-1.5.2.jar from the maven repository. I investigated the root cause and for some reason JarInputStream.getManifest was returning null for this Jar, causing an NPE. The attached patch inserts a null check for Jars which return a null Manifest.

 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Charles Oliver Nutter added a comment - 21/Oct/07 10:38 PM
Fixed on trunk and 1.1 branch