JRuby

'public_instance_methods' different from MRI within Rake (breaking Needle)

Details

  • Number of attachments :
    0

Description

The 'public_instance_methods' method reports different results for MRI and JRuby when running within Rake. Even though they report the same ancestors of self's class, the methods differ.

In particular, methods from FileUtils are not listed in public_instance_methods from MRI but they are in JRuby.

Reproduced with this code in a Rakefile, then run with Rake 0.7.3 on both:

class << self
p ancestors
p public_instance_methods
end

MRI gives this:

[Object, RakeFileUtils, FileUtils, FileUtils::StreamUtils_, Kernel]
["methods", "instance_eval", "dup", "require_gem", "instance_variables", "instance_of?", "extend", "eql?", "taguri", "id", "hash", "singleton_methods", "include", "taguri=", "taint", "instance_variable_get", "frozen?", "kind_of?", "method", "to_a", "display", "type", "protected_methods", "public", "instance_variable_set", "is_a?", "respond_to?", "to_s", "to_yaml", "object_id", "class", "private_methods", "==", "tainted?", "require", "__id__", "===", "untaint", "nil?", "to_yaml_style", "inspect", "send", "=~", "clone", "public_methods", "private", "__send__", "freeze", "equal?", "to_yaml_properties", "gem"]

While JRuby gives this:

["public", "include", "private", "to_s", "java_kind_of?", "to_yaml_node", "file", "multitask", "taguri", "desc", "namespace", "timeout", "Rational", "to_yaml_properties", "include_class", "task", "directory", "file_create", "import", "rule", "to_yaml", "to_yaml_style", "sh", "chmod", "ln_s", "mv", "symlink", "install", "nowrite", "safe_unlink", "rm_f", "copy", "ln", "mkpath", "cp_r", "mkdir", "mkdir_p", "chdir", "move", "rmdir", "chown_R", "ln_sf", "cp", "chown", "ruby", "link", "remove", "rm", "rmtree", "chmod_R", "rm_r", "cd", "makedirs", "verbose", "touch", "when_writing", "rm_rf", "split_all", "fu_world_writable?", "safe_ln", "object_id", "frozen?", "eql?", "=~", "methods", "to_a", "tainted?", "javax", "trap", "taint", "public_methods", "dup", "method", "==", "singleton_methods", "is_a?", "instance_eval", "equal?", "instance_variable_get", "com", "instance_of?", "hash", "inspect", "java", "org", "__id__", "clone", "__send__", "id", "instance_variable_set", "send", "gem", "untaint", "class", "protected_methods", "kind_of?", "require_gem", "instance_variables", "display", "extend", "freeze", "private_methods", "nil?", "type", "===", "instance_exec", "require", "respond_to?"]

I have a problem with Needle 1.3.0 breaking because of this. In a more complex situation, it tries to call 'undef_method' on a method returned by 'public_instance_methods', but that method isn't "there", causing an error. (But it works in the simpler situation above).

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. JRUBY-2247 Object#methods is incorrect in some cases

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Anders Bengtsson added a comment -

Sorry, the JRuby output should be this (first line was missing above):

[Object, RakeFileUtils, FileUtils, FileUtils::StreamUtils_, Kernel]
["public", "include", "private", "to_s", "java_kind_of?", "to_yaml_node", "file", "multitask", "taguri", "desc", "namespace", "timeout", "Rational", "to_yaml_properties", "include_class", "task", "directory", "file_create", "import", "rule", "to_yaml", "to_yaml_style", "sh", "chmod", "ln_s", "mv", "symlink", "install", "nowrite", "safe_unlink", "rm_f", "copy", "ln", "mkpath", "cp_r", "mkdir", "mkdir_p", "chdir", "move", "rmdir", "chown_R", "ln_sf", "cp", "chown", "ruby", "link", "remove", "rm", "rmtree", "chmod_R", "rm_r", "cd", "makedirs", "verbose", "touch", "when_writing", "rm_rf", "split_all", "fu_world_writable?", "safe_ln", "object_id", "frozen?", "eql?", "=~", "methods", "to_a", "tainted?", "javax", "trap", "taint", "public_methods", "dup", "method", "==", "singleton_methods", "is_a?", "instance_eval", "equal?", "instance_variable_get", "com", "instance_of?", "hash", "inspect", "java", "org", "__id__", "clone", "__send__", "id", "instance_variable_set", "send", "gem", "untaint", "class", "protected_methods", "kind_of?", "require_gem", "instance_variables", "display", "extend", "freeze", "private_methods", "nil?", "type", "===", "instance_exec", "require", "respond_to?"]

Show
Anders Bengtsson added a comment - Sorry, the JRuby output should be this (first line was missing above): [Object, RakeFileUtils, FileUtils, FileUtils::StreamUtils_, Kernel] ["public", "include", "private", "to_s", "java_kind_of?", "to_yaml_node", "file", "multitask", "taguri", "desc", "namespace", "timeout", "Rational", "to_yaml_properties", "include_class", "task", "directory", "file_create", "import", "rule", "to_yaml", "to_yaml_style", "sh", "chmod", "ln_s", "mv", "symlink", "install", "nowrite", "safe_unlink", "rm_f", "copy", "ln", "mkpath", "cp_r", "mkdir", "mkdir_p", "chdir", "move", "rmdir", "chown_R", "ln_sf", "cp", "chown", "ruby", "link", "remove", "rm", "rmtree", "chmod_R", "rm_r", "cd", "makedirs", "verbose", "touch", "when_writing", "rm_rf", "split_all", "fu_world_writable?", "safe_ln", "object_id", "frozen?", "eql?", "=~", "methods", "to_a", "tainted?", "javax", "trap", "taint", "public_methods", "dup", "method", "==", "singleton_methods", "is_a?", "instance_eval", "equal?", "instance_variable_get", "com", "instance_of?", "hash", "inspect", "java", "org", "__id__", "clone", "__send__", "id", "instance_variable_set", "send", "gem", "untaint", "class", "protected_methods", "kind_of?", "require_gem", "instance_variables", "display", "extend", "freeze", "private_methods", "nil?", "type", "===", "instance_exec", "require", "respond_to?"]
Hide
Permalink
Anders Bengtsson added a comment -

A better reproduction of the same problem is found in JRUBY-1188.

Show
Anders Bengtsson added a comment - A better reproduction of the same problem is found in JRUBY-1188 .
Hide
Permalink
Charles Oliver Nutter added a comment -

Clean up public/private/protected instance/class methods for 1.1, using Marcin's diff script and this bug plus JRUBY-1188.

Show
Charles Oliver Nutter added a comment - Clean up public/private/protected instance/class methods for 1.1, using Marcin's diff script and this bug plus JRUBY-1188 .
Hide
Permalink
Marcin Mielzynski added a comment -

There is also an issue with singleton_methods that shouldn't use isPublic to filter the resulting array.
The script needs to be modified to catch singleton method differences too.

Show
Marcin Mielzynski added a comment - There is also an issue with singleton_methods that shouldn't use isPublic to filter the resulting array. The script needs to be modified to catch singleton method differences too.
Hide
Permalink
Charles Oliver Nutter added a comment -

Punting issues from 1.1 RC2 to 1.1 final.

Show
Charles Oliver Nutter added a comment - Punting issues from 1.1 RC2 to 1.1 final.
Hide
Permalink
Charles Oliver Nutter added a comment -

Here's output from trunk today:

~/NetBeansProjects/jruby &#10132; ruby test_public_methods.rb 
[Object, Kernel]
["==", "===", "=~", "__id__", "__send__", "class", "clone", "display", "dup", "eql?", "equal?", "extend", "freeze", "frozen?", "hash", "id", "include", "inspect", "instance_eval", "instance_of?", "instance_variable_defined?", "instance_variable_get", "instance_variable_set", "instance_variables", "is_a?", "kind_of?", "method", "methods", "nil?", "object_id", "private", "private_methods", "protected_methods", "public", "public_methods", "respond_to?", "send", "singleton_methods", "taint", "tainted?", "to_a", "to_s", "type", "untaint"]
~/NetBeansProjects/jruby &#10132; jruby test_public_methods.rb 
[Object, Kernel]
["==", "===", "=~", "__id__", "__send__", "class", "clone", "display", "dup", "eql?", "equal?", "extend", "freeze", "frozen?", "hash", "id", "inspect", "instance_eval", "instance_exec", "instance_of?", "instance_variable_defined?", "instance_variable_get", "instance_variable_set", "instance_variables", "is_a?", "kind_of?", "method", "methods", "nil?", "object_id", "private_methods", "protected_methods", "public_methods", "respond_to?", "send", "singleton_methods", "taint", "tainted?", "to_a", "to_s", "type", "untaint"]

The differences are:

  • JRuby has extra: include, instance_exec
  • JRuby is missing: private, public

So it's much closer now. The remaining methods may be the ones added to the toplevel singleton, so we're just not filtering them out correctly?

Show
Charles Oliver Nutter added a comment - Here's output from trunk today: ~/NetBeansProjects/jruby &#10132; ruby test_public_methods.rb [Object, Kernel] ["==", "===", "=~", "__id__", "__send__", "class", "clone", "display", "dup", "eql?", "equal?", "extend", "freeze", "frozen?", "hash", "id", "include", "inspect", "instance_eval", "instance_of?", "instance_variable_defined?", "instance_variable_get", "instance_variable_set", "instance_variables", "is_a?", "kind_of?", "method", "methods", "nil?", "object_id", "private", "private_methods", "protected_methods", "public", "public_methods", "respond_to?", "send", "singleton_methods", "taint", "tainted?", "to_a", "to_s", "type", "untaint"] ~/NetBeansProjects/jruby &#10132; jruby test_public_methods.rb [Object, Kernel] ["==", "===", "=~", "__id__", "__send__", "class", "clone", "display", "dup", "eql?", "equal?", "extend", "freeze", "frozen?", "hash", "id", "inspect", "instance_eval", "instance_exec", "instance_of?", "instance_variable_defined?", "instance_variable_get", "instance_variable_set", "instance_variables", "is_a?", "kind_of?", "method", "methods", "nil?", "object_id", "private_methods", "protected_methods", "public_methods", "respond_to?", "send", "singleton_methods", "taint", "tainted?", "to_a", "to_s", "type", "untaint"] The differences are: JRuby has extra: include, instance_exec JRuby is missing: private, public So it's much closer now. The remaining methods may be the ones added to the toplevel singleton, so we're just not filtering them out correctly?
Hide
Permalink
Charles Oliver Nutter added a comment -

Oops, mine wasn't running rake, so I suppose there's a number of other methods that get pulled in there. But probably the same issue?

Show
Charles Oliver Nutter added a comment - Oops, mine wasn't running rake, so I suppose there's a number of other methods that get pulled in there. But probably the same issue?
Hide
Permalink
Thomas E Enebo added a comment -

Not enough time. Bumping.

Show
Thomas E Enebo added a comment - Not enough time. Bumping.
Hide
Permalink
Thomas E Enebo added a comment -

Daniel has a smaller testcase involving a core class:

p Dir.public_instance_methods(false)
 
C:\Documents and Settings\djberge\workspace\facade>ruby test.rb
["tell", "each", "path", "pos", "close", "read", "rewind", "pos=", "seek"]
 
C:\Documents and Settings\djberge\workspace\facade>jruby test.rb
["initialize", "rewind", "each", "tell", "close", "pos", "pos=", "seek", "path", "entries", "read"]
Show
Thomas E Enebo added a comment - Daniel has a smaller testcase involving a core class: p Dir.public_instance_methods(false) C:\Documents and Settings\djberge\workspace\facade>ruby test.rb ["tell", "each", "path", "pos", "close", "read", "rewind", "pos=", "seek"] C:\Documents and Settings\djberge\workspace\facade>jruby test.rb ["initialize", "rewind", "each", "tell", "close", "pos", "pos=", "seek", "path", "entries", "read"]
Hide
Permalink
Bill Dortch added a comment -

Also:

MRI

> Math.public_methods(false)
=> ["acosh", "class_eval", "const_missing", "private_instance_methods", "tan", ">=", "<=", "log10",
"to_s", "private_class_method", "sinh", "<", "include?", "public_instance_methods", "cos", "erf",
"private_method_defined?", ">", "name", "exp", "const_get", "atan", "method_defined?", "ldexp", 
"included_modules", "class_variables", "asinh", "autoload?", "acos", "const_defined?", "sqrt",
"module_eval", "tanh", "protected_method_defined?", "erfc", "protected_instance_methods", "sin",
"log", "autoload", "ancestors", "instance_method", "const_set", "cosh", "public_class_method",
"instance_methods",  "atan2", "hypot", "public_method_defined?", "class_variable_defined?",
"atanh", "<=>", "freeze", "constants", "asin", "==", "===", "frexp"]

JRuby

> Math.public_methods(false)
=> []

Actual Math methods also don't show up in Math.methods or Math.public_methods.

Show
Bill Dortch added a comment - Also: MRI > Math.public_methods(false) => ["acosh", "class_eval", "const_missing", "private_instance_methods", "tan", ">=", "<=", "log10", "to_s", "private_class_method", "sinh", "<", "include?", "public_instance_methods", "cos", "erf", "private_method_defined?", ">", "name", "exp", "const_get", "atan", "method_defined?", "ldexp", "included_modules", "class_variables", "asinh", "autoload?", "acos", "const_defined?", "sqrt", "module_eval", "tanh", "protected_method_defined?", "erfc", "protected_instance_methods", "sin", "log", "autoload", "ancestors", "instance_method", "const_set", "cosh", "public_class_method", "instance_methods", "atan2", "hypot", "public_method_defined?", "class_variable_defined?", "atanh", "<=>", "freeze", "constants", "asin", "==", "===", "frexp"] JRuby > Math.public_methods(false) => [] Actual Math methods also don't show up in Math.methods or Math.public_methods.
Hide
Permalink
Charles Oliver Nutter added a comment -

This is also the source of some ActionPack failures, even today in JRuby 1.2-dev:

$ irb
>> module M; protected; attr_reader :foo end
=> nil
>> class C; include M end
=> C
>> C.public_instance_methods.include?('foo')
=> false
 
$ jirb
>> module M; protected; attr_reader :foo end
=> nil
>> class C; include M end
=> C
>> C.public_instance_methods.include?('foo')
=> true
Show
Charles Oliver Nutter added a comment - This is also the source of some ActionPack failures, even today in JRuby 1.2-dev: $ irb >> module M; protected; attr_reader :foo end => nil >> class C; include M end => C >> C.public_instance_methods.include?('foo') => false $ jirb >> module M; protected; attr_reader :foo end => nil >> class C; include M end => C >> C.public_instance_methods.include?('foo') => true
Hide
Permalink
Charles Oliver Nutter added a comment -

Marking for 1.2 because it breaks some Rails tests.

Show
Charles Oliver Nutter added a comment - Marking for 1.2 because it breaks some Rails tests.
Hide
Permalink
Charles Oliver Nutter added a comment -

Unmarking for 1.2 because the failures were visibility-related.

Show
Charles Oliver Nutter added a comment - Unmarking for 1.2 because the failures were visibility-related.
Hide
Permalink
Thomas E Enebo added a comment -

This has long been fixed I suspect. The last test case provided runs correctly now.

Show
Thomas E Enebo added a comment - This has long been fixed I suspect. The last test case provided runs correctly now.

People

  • Assignee:
    Thomas E Enebo
    Reporter:
    Anders Bengtsson
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: