JRuby

Rubinius core/thread_spec failures

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: JRuby 1.0.3, JRuby 1.1RC2
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    1

Description

There's three of these, all the same. Probably the same issue.

1)
NativeException in 'For a Thread instance join should return the thread when it is finished'
java.lang.NullPointerException: null
EvaluationState.java:554:in `org.jruby.evaluator.EvaluationState.callNode'
EvaluationState.java:207:in `org.jruby.evaluator.EvaluationState.evalInternal'
EvaluationState.java:548:in `org.jruby.evaluator.EvaluationState.callNode'
EvaluationState.java:207:in `org.jruby.evaluator.EvaluationState.evalInternal'
EvaluationState.java:531:in `org.jruby.evaluator.EvaluationState.blockNode'
EvaluationState.java:201:in `org.jruby.evaluator.EvaluationState.evalInternal'
EvaluationState.java:164:in `org.jruby.evaluator.EvaluationState.eval'
Block.java:220:in `org.jruby.runtime.Block.yield'
RubyObject.java:840:in `org.jruby.RubyObject$3.execute'
RubyModule.java:1199:in `org.jruby.RubyModule.executeUnder'
RubyObject.java:823:in `org.jruby.RubyObject.yieldUnder'
RubyObject.java:769:in `org.jruby.RubyObject.specificEval'
RubyObject.java:1319:in `org.jruby.RubyObject.instance_eval'
null:-1:in `org.jruby.RubyObjectInvokerinstance_evalxx1.call'
InvocationCallback.java:49:in `org.jruby.runtime.callback.InvocationCallback.execute'
FullFunctionCallbackMethod.java:78:in `org.jruby.internal.runtime.methods.FullFunctionCallbackMethod.internalCall'
DynamicMethod.java:79:in `org.jruby.internal.runtime.methods.DynamicMethod.call'
EvaluationState.java:581:in `org.jruby.evaluator.EvaluationState.callNode'
EvaluationState.java:207:in `org.jruby.evaluator.EvaluationState.evalInternal'
EvaluationState.java:531:in `org.jruby.evaluator.EvaluationState.blockNode'
EvaluationState.java:201:in `org.jruby.evaluator.EvaluationState.evalInternal'

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Charles Oliver Nutter added a comment -

Look at Rubinius thread specs for 1.1

Show
Charles Oliver Nutter added a comment - Look at Rubinius thread specs for 1.1
Hide
Permalink
Charles Oliver Nutter added a comment -

NPEs are right out. Fix for 1.1, backport to 1.0.2 if possible.

Show
Charles Oliver Nutter added a comment - NPEs are right out. Fix for 1.1, backport to 1.0.2 if possible.
Hide
Permalink
Charles Oliver Nutter added a comment -

Bumping off 1.0.2.

Show
Charles Oliver Nutter added a comment - Bumping off 1.0.2.
Hide
Permalink
Kjetil Ødegaard added a comment -

Here's a small patch for this. It passes all tests and specs, but I haven't tested it further.

Show
Kjetil Ødegaard added a comment - Here's a small patch for this. It passes all tests and specs, but I haven't tested it further.
Hide
Permalink
Kjetil Ødegaard added a comment -

The patch should also handle the thread spec "join with a timeout should return nil if it is not finished" with a non-zero time-out (not currently tested in the spec).

Show
Kjetil Ødegaard added a comment - The patch should also handle the thread spec "join with a timeout should return nil if it is not finished" with a non-zero time-out (not currently tested in the spec).
Hide
Permalink
Ola Bini added a comment -

Fixed on trunk.

Show
Ola Bini added a comment - Fixed on trunk.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.