[#JRUBY-1067] Rubinius core/thread_spec failures

JRuby

Rubinius core/thread_spec failures

Created: 01/Jun/07 01:53 AM Updated: 22/Dec/07 06:26 AM

Component/s:

None

Affects Version/s:

None

Fix Version/s:

JRuby 1.0.3, JRuby 1.1RC2

Time Tracking:

Not Specified

File Attachments:

jruby-1067.patch (2 kb)

Description

« Hide

There's three of these, all the same. Probably the same issue.

1)
NativeException in 'For a Thread instance join should return the thread when it is finished'
java.lang.NullPointerException: null
EvaluationState.java:554:in `org.jruby.evaluator.EvaluationState.callNode'
EvaluationState.java:207:in `org.jruby.evaluator.EvaluationState.evalInternal'
EvaluationState.java:548:in `org.jruby.evaluator.EvaluationState.callNode'
EvaluationState.java:207:in `org.jruby.evaluator.EvaluationState.evalInternal'
EvaluationState.java:531:in `org.jruby.evaluator.EvaluationState.blockNode'
EvaluationState.java:201:in `org.jruby.evaluator.EvaluationState.evalInternal'
EvaluationState.java:164:in `org.jruby.evaluator.EvaluationState.eval'
Block.java:220:in `org.jruby.runtime.Block.yield'
RubyObject.java:840:in `org.jruby.RubyObject$3.execute'
RubyModule.java:1199:in `org.jruby.RubyModule.executeUnder'
RubyObject.java:823:in `org.jruby.RubyObject.yieldUnder'
RubyObject.java:769:in `org.jruby.RubyObject.specificEval'
RubyObject.java:1319:in `org.jruby.RubyObject.instance_eval'
null:-1:in `org.jruby.RubyObjectInvokerinstance_evalxx1.call'
InvocationCallback.java:49:in `org.jruby.runtime.callback.InvocationCallback.execute'
FullFunctionCallbackMethod.java:78:in `org.jruby.internal.runtime.methods.FullFunctionCallbackMethod.internalCall'
DynamicMethod.java:79:in `org.jruby.internal.runtime.methods.DynamicMethod.call'
EvaluationState.java:581:in `org.jruby.evaluator.EvaluationState.callNode'
EvaluationState.java:207:in `org.jruby.evaluator.EvaluationState.evalInternal'
EvaluationState.java:531:in `org.jruby.evaluator.EvaluationState.blockNode'
EvaluationState.java:201:in `org.jruby.evaluator.EvaluationState.evalInternal'

All

Comments

Work Log

Change History

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Charles Oliver Nutter - 23/Oct/07 01:11 PM

Look at Rubinius thread specs for 1.1

[ Permlink | « Hide ]

Charles Oliver Nutter - 23/Oct/07 01:40 PM

NPEs are right out. Fix for 1.1, backport to 1.0.2 if possible.

[ Permlink | « Hide ]

Charles Oliver Nutter - 30/Oct/07 02:09 AM

Bumping off 1.0.2.

[ Permlink | « Hide ]

Kjetil Ødegaard - 01/Nov/07 03:17 PM

Here's a small patch for this. It passes all tests and specs, but I haven't tested it further.

[ Permlink | « Hide ]

Kjetil Ødegaard - 01/Nov/07 03:20 PM

The patch should also handle the thread spec "join with a timeout should return nil if it is not finished" with a non-zero time-out (not currently tested in the spec).

[ Permlink | « Hide ]

Ola Bini - 29/Nov/07 08:54 AM

Fixed on trunk.