jMock

Upgrade to Hamcrest 1.2

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.6.0
  • Fix Version/s: 2.6.0
  • Component/s: JMock 2.x.x Library
  • Labels:
    None
  • Number of attachments :
    0

Description

Upgrade to Hamcrest 1.2 libraries

Issue Links

This issue is superceded by:
JMOCK-257 deploy 2.6 RC2 in central maven repository or sonatype.org Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Steve Freeman added a comment -

upgraded

Show
Steve Freeman added a comment - upgraded
Hide
Permalink
Nat Pryce added a comment -

Hamcrest 1.2 breaks existing code (equalTo return type differs from version 1.1).

Show
Nat Pryce added a comment - Hamcrest 1.2 breaks existing code (equalTo return type differs from version 1.1).
Hide
Permalink
Pether Sorling added a comment -

Hippie warning on the delay on the 2.6 release

Show
Pether Sorling added a comment - Hippie warning on the delay on the 2.6 release
Hide
Permalink
Oli Bye added a comment -

In an effort to get 2.6 out I've tried to recreate the problem Nat found 2 years ago.

This is episode one.

https://github.com/olibye/jmock-library/commit/585cee5c2aab95dddb8e885918ccf32abee884f9

I've faithfully rebuilt and added the hamcrest-unit-test-1.2.jar from the hamcrest source.
I've also setup eclipse to use a real Java1.5 compiler (not just source compatibility.

Next I'm going to roll forwards to using a Java1.6 compiler but in 1.5 source and target compatibility mode (as per the build.xml)

Show
Oli Bye added a comment - In an effort to get 2.6 out I've tried to recreate the problem Nat found 2 years ago. This is episode one. https://github.com/olibye/jmock-library/commit/585cee5c2aab95dddb8e885918ccf32abee884f9 I've faithfully rebuilt and added the hamcrest-unit-test-1.2.jar from the hamcrest source. I've also setup eclipse to use a real Java1.5 compiler (not just source compatibility. Next I'm going to roll forwards to using a Java1.6 compiler but in 1.5 source and target compatibility mode (as per the build.xml)
Hide
Permalink
Oli Bye added a comment - - edited

It appears from the SCM that Nat solved the hamcrest 1.2 issues using 1.3? (http://svn.codehaus.org/jmock/trunk/jmock2/lib/)

I've made a commit and pull request in my github fork that simply bumps hamcrest up to 1.3.0RC2
https://github.com/olibye/jmock-library/commit/2a60b2982ce3ebfd95e19b336cb3f66d7183c390

I've started a public mind map to track the options here http://www.mindmeister.com/125725560

I vote we forget 2.6.0 and make a 2.7 with hamcrest 1.3.0RC2 (Until you/we bump that up to a proper release too!)

Show
Oli Bye added a comment - - edited It appears from the SCM that Nat solved the hamcrest 1.2 issues using 1.3? (http://svn.codehaus.org/jmock/trunk/jmock2/lib/) I've made a commit and pull request in my github fork that simply bumps hamcrest up to 1.3.0RC2 https://github.com/olibye/jmock-library/commit/2a60b2982ce3ebfd95e19b336cb3f66d7183c390 I've started a public mind map to track the options here http://www.mindmeister.com/125725560 I vote we forget 2.6.0 and make a 2.7 with hamcrest 1.3.0RC2 (Until you/we bump that up to a proper release too!)
Hide
Permalink
Steve Freeman added a comment -

The thing to check is working with typed collections, Java seems to fall over at more than one level of generic.

Otherwise I'm up for your proposal.

Thanks for taking this on. Would you like access to Hamcrest too?

Show
Steve Freeman added a comment - The thing to check is working with typed collections, Java seems to fall over at more than one level of generic. Otherwise I'm up for your proposal. Thanks for taking this on. Would you like access to Hamcrest too?
Hide
Permalink
Oli Bye added a comment -

When you say "The thing to check..." does that mean you want me to write a test?
Or double check a particular test makes sense?

With respect to hamcrest, yes, I'm happy to help out with that too, although you've got an amazing number of languages in there that I'd have to brush up on (not a bad thing).

Oli

Show
Oli Bye added a comment - When you say "The thing to check..." does that mean you want me to write a test? Or double check a particular test makes sense? With respect to hamcrest, yes, I'm happy to help out with that too, although you've got an amazing number of languages in there that I'd have to brush up on (not a bad thing). Oli
Hide
Permalink
Oli Bye added a comment - - edited

Oops duplicate post

Show
Oli Bye added a comment - - edited Oops duplicate post
Hide
Permalink
Oli Bye added a comment -

Upgraded to hamcrest 1.3 in jmock-2.6.0-RC2 as part of JMOCK-257.
I couldn't compile 2.6.0-RC2 against hamcrest 1.2 (as Nat appears to have also found)

Show
Oli Bye added a comment - Upgraded to hamcrest 1.3 in jmock-2.6.0-RC2 as part of JMOCK-257. I couldn't compile 2.6.0-RC2 against hamcrest 1.2 (as Nat appears to have also found)

People

Vote (3)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.