jMock

Mockery depends on SingleThreadedImposteriser which is in the test source directory

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.6.0
  • Fix Version/s: 2.6.0
  • Component/s: JMock 2.x.x Library
  • Labels:
    None
  • Patch Submitted:
    Yes
  • Number of attachments :
    2

Description

org.jmock.Mockery currently depends on org.jmock.test.unit.lib.SingleThreadedImposteriser which is located in the test source folder thereby introducing a dependency from jmock.jar to jmock-tests.jar. To fix this I've moved test/org/jmock/test/unit/lib/SingleThreadedImposteriser.java to src/org/jmock/lib/SingleThreadedImposteriser.java. To prevent this happening in the future I've also updated the build.xml file so that the test files are compiled separately from the src files and placed into a separate directory (build/testclasses) to further prevent them being accidentally referenced.

  1. build.xml.patch
    18/Mar/09 7:05 PM
    2 kB
    Tom Palmer
  2. build-test.patch
    18/Mar/09 8:38 AM
    5 kB
    Tom Palmer

Activity

Hide
Nat Pryce added a comment -

Good catch. The code in Subversion head is still work in progress. 2.6.0 is not yet released. For issues with the code in subversion, it's better to just send an email to the developers or users mailing list, rather than raising a JIRA. We use JIRA for tracking issues against released versions.

Show
Nat Pryce added a comment - Good catch. The code in Subversion head is still work in progress. 2.6.0 is not yet released. For issues with the code in subversion, it's better to just send an email to the developers or users mailing list, rather than raising a JIRA. We use JIRA for tracking issues against released versions.
Hide
Nat Pryce added a comment -

I've moved the SingleThreadedImposteriser to the internal package. I haven't changed the build but will be happy to apply the change if you attach it in its own patch file.

Show
Nat Pryce added a comment - I've moved the SingleThreadedImposteriser to the internal package. I haven't changed the build but will be happy to apply the change if you attach it in its own patch file.
Hide
Tom Palmer added a comment -

Ok - the next patch (if there is one ) will go to the developers list but for completeness here's the updated build.xml patch. I suspect you might want to change the checked in Eclipse settings files so that test outputs to a separate directory from src but I'm an IntelliJ user and don't have a copy of eclipse around to edit those.

Show
Tom Palmer added a comment - Ok - the next patch (if there is one ) will go to the developers list but for completeness here's the updated build.xml patch. I suspect you might want to change the checked in Eclipse settings files so that test outputs to a separate directory from src but I'm an IntelliJ user and don't have a copy of eclipse around to edit those.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: