JiBX

Plugin does not search for binding definition files recursively.

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: JiBX 1.1
  • Fix Version/s: JiBX 1.2.3
  • Component/s: maven plugin
  • Labels:
    None
  • Environment:
    Windows XP, Eclipse 3.1
  • Number of attachments :
    2

Description

The maven-2 plugin does not search the directory for binding definition files recursively. I marked this as a bug because this is a regression from the maven-1 plugin.

Issue Links

is depended upon by

Improvement - An improvement or enhancement to an existing feature or task. JIBX-300 Plugin do not include bindings file in sub directories

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.
is duplicated by

Bug - A problem which impairs or prevents the functions of the product. JIBX-362 Maven JiBX Plugin doesn't search subdirectories

  • Major - Major loss of function.
  • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.

Improvement - An improvement or enhancement to an existing feature or task. JIBX-300 Plugin do not include bindings file in sub directories

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Dennis Sosnoski added a comment -

There's no one available for Maven support, but volunteers are welcome...

Show
Dennis Sosnoski added a comment - There's no one available for Maven support, but volunteers are welcome...
Hide
Permalink
dereka denis alex added a comment -

add recursive find bind files:

  • dependency apache.oro
    + dependency org.codehaus.plexus-utils
Show
dereka denis alex added a comment - add recursive find bind files: dependency apache.oro + dependency org.codehaus.plexus-utils
Hide
Permalink
dereka denis alex added a comment -

add recursive find bind files:
-dependency apache.oro
+ dependency org.codehaus.plexus-utils

Show
dereka denis alex added a comment - add recursive find bind files: -dependency apache.oro + dependency org.codehaus.plexus-utils
Hide
Permalink
Don Corley added a comment -

Before I attempt to fix this code I just want to make sure I'm clear on what the expected behavior should be.

If I am correct, in the current plugin you supply a directory for the binding file and a filter for that directory:

<directory>src/main/jibx/bindings</directory>
<includes>
<includes>*binding.xml</includes>
</includes>

This includes all files starting with binding.xml in the src/main/jibx/bindings directory.

I think what you want is to include all the files starting with binding.xml in the src/main/jibx/bindings and any sub-directories.

Is this correct? The only reason I can see for doing this is if there are binding files spread over several directories. Now, there is no way to include them all. Am I correct? Sorry for the dumb questions, but if I install your patches, I want to make sure I can test and document them correctly.

If you could add a comment for the correct behavior, I would appreciate it.

Show
Don Corley added a comment - Before I attempt to fix this code I just want to make sure I'm clear on what the expected behavior should be. If I am correct, in the current plugin you supply a directory for the binding file and a filter for that directory: <directory>src/main/jibx/bindings</directory> <includes> <includes>*binding.xml</includes> </includes> This includes all files starting with binding.xml in the src/main/jibx/bindings directory. I think what you want is to include all the files starting with binding.xml in the src/main/jibx/bindings and any sub-directories. Is this correct? The only reason I can see for doing this is if there are binding files spread over several directories. Now, there is no way to include them all. Am I correct? Sorry for the dumb questions, but if I install your patches, I want to make sure I can test and document them correctly. If you could add a comment for the correct behavior, I would appreciate it.
Hide
Permalink
Don Corley added a comment -

The <includes>, <excludes> tags now follow the standard maven filter format.
"**.xml" or "/.xml" will now include all the xml files in the <directory> tree.
Thanks to Joost and Benoit for their code!
CompileBindingMojo.java
new revision: 1.2; previous revision: 1.1
SchemaCodeGenMojo.java
new revision: 1.5; previous revision: 1.4

Show
Don Corley added a comment - The <includes>, <excludes> tags now follow the standard maven filter format. "* *.xml" or " / .xml" will now include all the xml files in the <directory> tree. Thanks to Joost and Benoit for their code! CompileBindingMojo.java new revision: 1.2; previous revision: 1.1 SchemaCodeGenMojo.java new revision: 1.5; previous revision: 1.4

People

  • Assignee:
    Don Corley
    Reporter:
    Joost Cassee
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: