Jetty

Exceptions encountered in terracotta session scavenging are lost and scavenging stops

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 6.1.15
  • Fix Version/s: 6.1.16
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    1

Description

The scavenging done in the TerracottaSessionManager is driven with a single threaded ScheduledExecutorService. Unfortunately it seems that if an exception occurs during scavenge() two bad things happen:

1) The exception is not reported anywhere
2) The fixed rate scavenge task is removed from scheduling so no more scavenging happens after that

This seems to be standard behavior for ScheduledExecutorService it seems but doesn't seem correct for the usage in the terracotta session manager.

As a point of comparsion, HashSessionManager catches all exceptions and logs a warning in scavenge()

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jan Bartel added a comment -

Tim also separately posted a patch for some other niggles he found. I'm attaching it to this issue.

Jan

Show
Jan Bartel added a comment - Tim also separately posted a patch for some other niggles he found. I'm attaching it to this issue. Jan
Hide
Permalink
Jan Bartel added a comment -

Tim,

Simone had already addressed some of your issues, so the patch you sent didn't apply cleanly to the code. I think I've picked my way through it and have incorporated all your changes. The unit tests are all passing. Could you:

a) review the code and make sure it does address all concerns
b) subject it to some load tests

thanks,
Jan

Show
Jan Bartel added a comment - Tim, Simone had already addressed some of your issues, so the patch you sent didn't apply cleanly to the code. I think I've picked my way through it and have incorporated all your changes. The unit tests are all passing. Could you: a) review the code and make sure it does address all concerns b) subject it to some load tests thanks, Jan
Hide
Permalink
Tim Eck added a comment -

that code looks good to me and passes our invalidation load test with flying colors. thanks

Show
Tim Eck added a comment - that code looks good to me and passes our invalidation load test with flying colors. thanks

People

  • Assignee:
    Jan Bartel
    Reporter:
    Tim Eck
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: