Jetty

NullPointerException in Response when performing redirect to wrong relative URL

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 6.1.14
  • Fix Version/s: 6.1.15.rc4
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    1

Description

When redirecting to a non-existing relative URL, a NPE gets thrown in org.mortbay.jetty.Response.sendRedirect on line 397. This happens as URI.canonicalPath(String) can return null if "the path tries to .. above its root". E.g. redirecting from "/foo/" to "../bar" results in a NPE.
Please have a look at the attached example that produces the Exception.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Greg Wilkins added a comment -

probably best to throw an illegalArgumentException if the canonical is null

Show
Greg Wilkins added a comment - probably best to throw an illegalArgumentException if the canonical is null
Hide
Permalink
David Yu added a comment -

IllegalStateException thrown when path is above root.

Show
David Yu added a comment - IllegalStateException thrown when path is above root.

People

  • Assignee:
    David Yu
    Reporter:
    Michael Sparer
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: