Jetty
  1. Jetty
  2. JETTY-846

Support Include and Exclude resources during overlay when jetty:run

    Details

    • Type: New Feature New Feature
    • Status: Resolved Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 6.1.14
    • Fix Version/s: 9.0.0
    • Component/s: Maven
    • Labels:
      None
    • Number of attachments :
      0

      Description

      Now, jetty maven plugin support the overlay during jetty:run. But, it doesn't support to exclude or include resources during overlay.

      i.e. Can jetty:run support the feature

      Previous Discussion:
      http://www.nabble.com/jetty%3Arun-didn't-work-with-overlay-to21122671.html

        Activity

        Hide
        Alfred Chan added a comment -

        i.e. Can jetty:run support the feature that similar to maven-war-plugin to exclude or include the resources from the parent WARs?
        http://maven.apache.org/plugins/maven-war-plugin/overlays.html

        Show
        Alfred Chan added a comment - i.e. Can jetty:run support the feature that similar to maven-war-plugin to exclude or include the resources from the parent WARs? http://maven.apache.org/plugins/maven-war-plugin/overlays.html
        Jan Bartel made changes -
        Field Original Value New Value
        Assignee David Yu [ dyu ]
        Hide
        Barry Pitman added a comment -

        Related to this issue - it would be handy if one could filter the resources that are incorporated from an overlay, similar to the method used in the war plugin.

        Show
        Barry Pitman added a comment - Related to this issue - it would be handy if one could filter the resources that are incorporated from an overlay, similar to the method used in the war plugin.
        Greg Wilkins made changes -
        Assignee David Yu [ dyu ]
        Michael Gorovoy made changes -
        Assignee Jesse McConnell [ jesse ]
        Hide
        Peter Parente added a comment -

        Agreed. This would be handy when doing web development that overlays JS libs from various separate modules into a single js/ path of sorts. Right now, the first module targeted to js/ wins and none of the others show up, even if unpackOverlays is true.

        Show
        Peter Parente added a comment - Agreed. This would be handy when doing web development that overlays JS libs from various separate modules into a single js/ path of sorts. Right now, the first module targeted to js/ wins and none of the others show up, even if unpackOverlays is true.
        Hide
        Matt Fisher added a comment -

        This doesn't appear to be getting any love...
        Using WAR overlays is a basic, commonly used feature for creating a webapp. Shared resources are often push into a separate WAR so that they can be maintained in a single location and shared/overlayed among many other projects. In addition to sharing the resources, people commonly put parameters in them (such as an XML config file that has a database URL parameter) and apply different values based on Maven build profiles. Maven's WAR plugin handles this by allowing resources to be filtered after overlayed. However, there doesn't seem to be a way to filter those overlayed resources when using jetty:run. Running jetty:run-war can take quite a bit of time to build a WAR with overlays and doesn't offer a mechanism to edit JSPs in-place in a safe manner (other than in the build directory, which is not safe when running mvn clean).

        I am using maven-jetty-plugin 7.x, although this issue specifies 6.1.14.

        1) Is there a current feature that satisfies this request?
        2) If not, is this request going to be considered?

        Show
        Matt Fisher added a comment - This doesn't appear to be getting any love... Using WAR overlays is a basic, commonly used feature for creating a webapp. Shared resources are often push into a separate WAR so that they can be maintained in a single location and shared/overlayed among many other projects. In addition to sharing the resources, people commonly put parameters in them (such as an XML config file that has a database URL parameter) and apply different values based on Maven build profiles. Maven's WAR plugin handles this by allowing resources to be filtered after overlayed. However, there doesn't seem to be a way to filter those overlayed resources when using jetty:run. Running jetty:run-war can take quite a bit of time to build a WAR with overlays and doesn't offer a mechanism to edit JSPs in-place in a safe manner (other than in the build directory, which is not safe when running mvn clean). I am using maven-jetty-plugin 7.x, although this issue specifies 6.1.14. 1) Is there a current feature that satisfies this request? 2) If not, is this request going to be considered?
        Hide
        Benjamin Schrooten added a comment -

        Would love to have this capability.

        Show
        Benjamin Schrooten added a comment - Would love to have this capability.
        Jesse McConnell made changes -
        Assignee Jesse McConnell [ jesse ] Michael Gorovoy [ mgorovoy ]
        Jan Bartel made changes -
        Assignee Michael Gorovoy [ mgorovoy ] Jan Bartel [ janb ]
        Hide
        Daniel Bernstein added a comment -

        Also it would be nice if targetPath worked with jetty:run as well. I'm on maven-jetty-plugin 7.x as well. Thanks.

        Show
        Daniel Bernstein added a comment - Also it would be nice if targetPath worked with jetty:run as well. I'm on maven-jetty-plugin 7.x as well. Thanks.
        Hide
        Jan Bartel added a comment -

        Implemented parsing of maven-war-plugin configuration for overlays. From jetty-9.0.0.M3 onwards, the jetty maven plugin will use this information to order and honour includes/excludes on overlays.

        Show
        Jan Bartel added a comment - Implemented parsing of maven-war-plugin configuration for overlays. From jetty-9.0.0.M3 onwards, the jetty maven plugin will use this information to order and honour includes/excludes on overlays.
        Jan Bartel made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 9.0.0 [ 18947 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Jan Bartel
            Reporter:
            Alfred Chan
          • Votes:
            10 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: