Jetty

Use pre-built jsp-2.1 jars for jetty-6 and extract servlet-api-2.5 as an external module

Details

  • Type: Task Task
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 6.1.15.pre0
  • Component/s: HTTP, JSP
  • Labels:
    None
  • Number of attachments :
    0

Description

Do for jetty6 what we did for jetty7, which is to stop the jsp 2.1 code being checked out and rebuilt on every build of jetty. To do that, we need to replace the 2.1 module with a dependency on the jsp-2.1-glassfish and jsp-api-2.1-glassfish artifacts (built from the https://svn.codehaus.org/jetty/jsp/ sub-project).

To do that, we need to make a version of those artifacts that are compiled against the servlet 2.5 spec instead of the servlet 3.0 draft spec.

To do that, we need to extract the servlet-api-2.5 module out of jetty6 and put it into the https://svn.codehaus.org/jetty/servlet-api sub-project instead.

So the order of work is:

1. extract servlet-api-2.5 from jetty6 and put it into branch of the https://svn.codehaus.org/jetty/servlet-api subproject
2. change deps in jetty6 to point to new servlet jar
3. make branch of https://svn.codehaus.org/jetty/jsp/ sub-project and use new servlet 2.5 jar
4. update jetty6 to use new jsp-2.1 jars compiled against servlet 2.5

Issue Links

Activity

Hide
David Jencks added a comment -

You could also use the released geronimo spec jars for jsp 2.1 and servlet 2.5 and not build them yourself at all.

Show
David Jencks added a comment - You could also use the released geronimo spec jars for jsp 2.1 and servlet 2.5 and not build them yourself at all.
Hide
Jan Bartel added a comment -

Hi David,

I suppose that the geronimo servlet2.5 jar is built with jdk1.5? All of the other 2.5 jars I've found have been. We have always shipped a 2.5 built with jdk1.4 with jetty, as there is nothing in 2.5 itself that requires jdk1.5 (only jsp2.1), so users can upgrade to jetty6 but keep using jdk1.4 (with jsp2.0).

We could use geronimo's jsp2.1 - do you have both an api jar and a impl jar? For the impl, what's it's pedigree (sooooo many forks of jasper out there these days aren't there?). We'd probably investigate using this in jetty-7 rather than jetty-6, as we can experiment more in jetty-7.

cheers
Jan

Show
Jan Bartel added a comment - Hi David, I suppose that the geronimo servlet2.5 jar is built with jdk1.5? All of the other 2.5 jars I've found have been. We have always shipped a 2.5 built with jdk1.4 with jetty, as there is nothing in 2.5 itself that requires jdk1.5 (only jsp2.1), so users can upgrade to jetty6 but keep using jdk1.4 (with jsp2.0). We could use geronimo's jsp2.1 - do you have both an api jar and a impl jar? For the impl, what's it's pedigree (sooooo many forks of jasper out there these days aren't there?). We'd probably investigate using this in jetty-7 rather than jetty-6, as we can experiment more in jetty-7. cheers Jan
Hide
Jan Bartel added a comment -

First checkin to jetty-6. Have to use SNAPSHOTs of servlet-2.5-20081211 and jsp-api-2.1-glassfish and jsp-2.1-glassfish because maven release repo is not yet sync'ed,

Show
Jan Bartel added a comment - First checkin to jetty-6. Have to use SNAPSHOTs of servlet-2.5-20081211 and jsp-api-2.1-glassfish and jsp-2.1-glassfish because maven release repo is not yet sync'ed,
Hide
Jan Bartel added a comment -

I should also mention that the rpms and debians will be broken by this update and need fixing.

Show
Jan Bartel added a comment - I should also mention that the rpms and debians will be broken by this update and need fixing.
Hide
Jan Bartel added a comment -

Updated pom to released versions of servlet-api and jsp-2.1-glassfish jars as they are now in the maven repo.

Show
Jan Bartel added a comment - Updated pom to released versions of servlet-api and jsp-2.1-glassfish jars as they are now in the maven repo.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: