Jetty

Expose a system property FILE config in the plugin

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 6.1.15.rc5
  • Component/s: Maven
  • Labels:
    None
  • Number of attachments :
    1

Description

Instead of having to define explicitly the system keys-values directly in the configuration part of the jetty-run maven 2 plugins, it would be handy to offer a system-property-file configuration key that would aim to better decoupled the pom and the runtime configuration.

That's especially practical when project are generated against archetype with some jetty facilities for which we don't necessarily want the developer to fiddle too much in the pom (by example if the jetty plugins is defined in a super pom, we could simply expose a property jetty-system-property-file that would replace the system-property-file in the super-pom).

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Athena Yao added a comment -

I believe this can currently be done with Maven. See the filters property under http://maven.apache.org/pom.html#Build_Settings.

cheers,

Show
Athena Yao added a comment - I believe this can currently be done with Maven. See the filters property under http://maven.apache.org/pom.html#Build_Settings . cheers,
Hide
Permalink
Frederic Tardif added a comment -

If I understand correctly the filtering feature of maven, it can apply of resources on process-resource phase with a finite set of key values.

It the case stated above, the idea is to apply a configuration on the plugin without the pom needing to know how many properties will be passed to the mojo.

Show
Frederic Tardif added a comment - If I understand correctly the filtering feature of maven, it can apply of resources on process-resource phase with a finite set of key values. It the case stated above, the idea is to apply a configuration on the plugin without the pom needing to know how many properties will be passed to the mojo.
Hide
Permalink
Athena Yao added a comment -

I'm beginning to have an idea of the use case you're describing, but I'm still not sure I understand it completely. A concrete example for how you imagine this working would be useful.

Show
Athena Yao added a comment - I'm beginning to have an idea of the use case you're describing, but I'm still not sure I understand it completely. A concrete example for how you imagine this working would be useful.
Hide
Permalink
Jan Bartel added a comment -

Downgrading the priority a little on this improvement suggestion.

Show
Jan Bartel added a comment - Downgrading the priority a little on this improvement suggestion.
Hide
Permalink
Athena Yao added a comment -

Here's a patch for jetty6, exposing a system properties file.

System properties defined directly in the pom will override system properties that have been defined in a file, and system properties defined in a file will not override those defined in the pom.

If this looks okay, I'll update the wiki a well.

Show
Athena Yao added a comment - Here's a patch for jetty6, exposing a system properties file. System properties defined directly in the pom will override system properties that have been defined in a file, and system properties defined in a file will not override those defined in the pom. If this looks okay, I'll update the wiki a well.
Hide
Permalink
Athena Yao added a comment -

Other changes crept into that initial patch. Uploading a clean version.

Show
Athena Yao added a comment - Other changes crept into that initial patch. Uploading a clean version.
Hide
Permalink
Athena Yao added a comment -

Committed the patch to Jetty 6 and Jetty 7, and I've added

The new property is called systemPropertiesFile, and it takes a file name. Note that properties set via the systemProperties property, etc override those set in systemPropertiesFile.

Show
Athena Yao added a comment - Committed the patch to Jetty 6 and Jetty 7, and I've added The new property is called systemPropertiesFile, and it takes a file name. Note that properties set via the systemProperties property, etc override those set in systemPropertiesFile.
Hide
Permalink
Nathan Beach added a comment -

Hi: This is just meant as help / documentation for anyone who might run into the same problem. I think it may be related to this bug fix.

We auto-updated via maven to jetty-6.1.15.rc4 and our integration-test was suddenly broken. We started getting a stream of errors related to Spring configuration like:

20 Feb 2009 06:54:23,843-[main] WARN org.springframework.util.SystemPropertyUtils - Could not resolve placeholder 'web.properties' in [$

{web.properties}] as system property: neither system property nor environment variable found

${web.properties}

was defined in the maven base profiles.xml. We upgraded to the Jetty 7 pre-release and the problems went away. The problem also seems to be solved by reverting to jetty-6.1.14. Thanks / good luck...

NBB

Show
Nathan Beach added a comment - Hi: This is just meant as help / documentation for anyone who might run into the same problem. I think it may be related to this bug fix. We auto-updated via maven to jetty-6.1.15.rc4 and our integration-test was suddenly broken. We started getting a stream of errors related to Spring configuration like: 20 Feb 2009 06:54:23,843- [main] WARN org.springframework.util.SystemPropertyUtils - Could not resolve placeholder 'web.properties' in [$ {web.properties}] as system property: neither system property nor environment variable found ${web.properties} was defined in the maven base profiles.xml. We upgraded to the Jetty 7 pre-release and the problems went away. The problem also seems to be solved by reverting to jetty-6.1.14. Thanks / good luck... NBB
Hide
Permalink
Athena Yao added a comment -

Nathan,

Thank you for catching that! I've committed a fix to the 6.1 snapshot. Could you please check if this fixes the problems you were having?

Show
Athena Yao added a comment - Nathan, Thank you for catching that! I've committed a fix to the 6.1 snapshot. Could you please check if this fixes the problems you were having?
Hide
Permalink
Nathan Beach added a comment -

Athena – I wasn't able to download the snapshot, but I tested with the rc5 release and everything works fine now. Thanks!

Show
Nathan Beach added a comment - Athena – I wasn't able to download the snapshot, but I tested with the rc5 release and everything works fine now. Thanks!
Hide
Permalink
Ruchita Ghaskadvi added a comment - - edited

I am trying to use the "systemPropertiesFile" property for the plugin but the properties are not getting loaded. We are using Jetty version 6.1.26 and the documentation says it's "Available from Jetty 6.1.15rc4".

Can you please give more details and examples on how this is set? In the comments above, it says "it takes a file name". Does the file need to be in some particular location or can it take absolute file location?

Thanks in advance!

Show
Ruchita Ghaskadvi added a comment - - edited I am trying to use the "systemPropertiesFile" property for the plugin but the properties are not getting loaded. We are using Jetty version 6.1.26 and the documentation says it's "Available from Jetty 6.1.15rc4". Can you please give more details and examples on how this is set? In the comments above, it says "it takes a file name". Does the file need to be in some particular location or can it take absolute file location? Thanks in advance!

People

  • Assignee:
    Athena Yao
    Reporter:
    Frederic Tardif
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: