Jetty
  1. Jetty
  2. JETTY-811

Expose a system property FILE config in the plugin

    Details

    • Type: Improvement Improvement
    • Status: Resolved Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.1.15.rc5
    • Component/s: Maven
    • Labels:
      None
    • Number of attachments :
      1

      Description

      Instead of having to define explicitly the system keys-values directly in the configuration part of the jetty-run maven 2 plugins, it would be handy to offer a system-property-file configuration key that would aim to better decoupled the pom and the runtime configuration.

      That's especially practical when project are generated against archetype with some jetty facilities for which we don't necessarily want the developer to fiddle too much in the pom (by example if the jetty plugins is defined in a super pom, we could simply expose a property jetty-system-property-file that would replace the system-property-file in the super-pom).

        Activity

        Hide
        Athena Yao added a comment -

        Committed the patch to Jetty 6 and Jetty 7, and I've added

        The new property is called systemPropertiesFile, and it takes a file name. Note that properties set via the systemProperties property, etc override those set in systemPropertiesFile.

        Show
        Athena Yao added a comment - Committed the patch to Jetty 6 and Jetty 7, and I've added The new property is called systemPropertiesFile, and it takes a file name. Note that properties set via the systemProperties property, etc override those set in systemPropertiesFile.
        Hide
        Nathan Beach added a comment -

        Hi: This is just meant as help / documentation for anyone who might run into the same problem. I think it may be related to this bug fix.

        We auto-updated via maven to jetty-6.1.15.rc4 and our integration-test was suddenly broken. We started getting a stream of errors related to Spring configuration like:

        20 Feb 2009 06:54:23,843-[main] WARN org.springframework.util.SystemPropertyUtils - Could not resolve placeholder 'web.properties' in [$

        {web.properties}] as system property: neither system property nor environment variable found

        ${web.properties}

        was defined in the maven base profiles.xml. We upgraded to the Jetty 7 pre-release and the problems went away. The problem also seems to be solved by reverting to jetty-6.1.14. Thanks / good luck...

        NBB

        Show
        Nathan Beach added a comment - Hi: This is just meant as help / documentation for anyone who might run into the same problem. I think it may be related to this bug fix. We auto-updated via maven to jetty-6.1.15.rc4 and our integration-test was suddenly broken. We started getting a stream of errors related to Spring configuration like: 20 Feb 2009 06:54:23,843- [main] WARN org.springframework.util.SystemPropertyUtils - Could not resolve placeholder 'web.properties' in [$ {web.properties}] as system property: neither system property nor environment variable found ${web.properties} was defined in the maven base profiles.xml. We upgraded to the Jetty 7 pre-release and the problems went away. The problem also seems to be solved by reverting to jetty-6.1.14. Thanks / good luck... NBB
        Hide
        Athena Yao added a comment -

        Nathan,

        Thank you for catching that! I've committed a fix to the 6.1 snapshot. Could you please check if this fixes the problems you were having?

        Show
        Athena Yao added a comment - Nathan, Thank you for catching that! I've committed a fix to the 6.1 snapshot. Could you please check if this fixes the problems you were having?
        Hide
        Nathan Beach added a comment -

        Athena – I wasn't able to download the snapshot, but I tested with the rc5 release and everything works fine now. Thanks!

        Show
        Nathan Beach added a comment - Athena – I wasn't able to download the snapshot, but I tested with the rc5 release and everything works fine now. Thanks!
        Hide
        Ruchita Ghaskadvi added a comment - - edited

        I am trying to use the "systemPropertiesFile" property for the plugin but the properties are not getting loaded. We are using Jetty version 6.1.26 and the documentation says it's "Available from Jetty 6.1.15rc4".

        Can you please give more details and examples on how this is set? In the comments above, it says "it takes a file name". Does the file need to be in some particular location or can it take absolute file location?

        Thanks in advance!

        Show
        Ruchita Ghaskadvi added a comment - - edited I am trying to use the "systemPropertiesFile" property for the plugin but the properties are not getting loaded. We are using Jetty version 6.1.26 and the documentation says it's "Available from Jetty 6.1.15rc4". Can you please give more details and examples on how this is set? In the comments above, it says "it takes a file name". Does the file need to be in some particular location or can it take absolute file location? Thanks in advance!

          People

          • Assignee:
            Athena Yao
            Reporter:
            Frederic Tardif
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: