Jetty

Non-backward compatible API change in EnvEntry (missing constructor)

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 6.1.14
  • Fix Version/s: 6.1.15.pre0
  • Component/s: None
  • Labels:
    None
  • Environment:
    OS X, Java 5
  • Number of attachments :
    0

Description

As of 6.1.12 the two argument constructor 'public EnvEntry (String jndiName, Object objToBind)' has been removed. This means that WAR files with jetty-env.xml that worked in the past, with entries like:

<New id="injected_properties_path" class="org.mortbay.jetty.plus.naming.EnvEntry">
<Arg>injected_properties_path</Arg>
<Arg type="java.lang.String">file:///export/content/injected.properties</Arg>
</New>

no longer work as of 6.1.12.

A simple fix would be to reintroduce the missing constructor:

public EnvEntry (String jndiName, Object objToBind)
throws NamingException

{ this(jndiName, objToBind, false); }

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. JETTY-886 Jetty Plugin fails while reading jetty-env.xml file.

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

Bug - A problem which impairs or prevents the functions of the product. JETTY-768 JNDI lookup doesn't work - NameNotFoundException

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Mike T. Miller added a comment -

Ack, my formatting was completely horked in the original description and there doesn't appear to be a way to edit it.

It should read:

public EnvEntry (String jndiName, Object objToBind)
throws NamingException
{
this(jndiName, objToBind, false);
}

Show
Mike T. Miller added a comment - Ack, my formatting was completely horked in the original description and there doesn't appear to be a way to edit it. It should read: public EnvEntry (String jndiName, Object objToBind) throws NamingException { this(jndiName, objToBind, false); }
Hide
Permalink
Mike T. Miller added a comment -

Sigh, once more, with feeling:

snippet from EnvEntry.java
public EnvEntry (String jndiName, Object objToBind)
  throws NamingException
{
  this(jndiName, objToBind, false);
}
Show
Mike T. Miller added a comment - Sigh, once more, with feeling: snippet from EnvEntry.java public EnvEntry ( String jndiName, Object objToBind) throws NamingException { this (jndiName, objToBind, false ); }
Hide
Permalink
Jan Bartel added a comment -

Hi Mike,

Yeah, I guess I could put that one back in. The constructor that your code snippet shows cannot return
however, as it conflicts with this constructor:

EnvEntry(Object scope, String jndiName, Object objToBind)

The EnvEntry (String jndiName, Object objToBind, boolean override) constructor conflicted with the one
above because the xml->java parser selects the constructor above and binds what should be the name
as the scope, the object as the name and the override as the value. When I deleted this constructor, I
also deleted the 2 arg constructor that called it.

I'll look at putting that back in.

cheers
Jan

Show
Jan Bartel added a comment - Hi Mike, Yeah, I guess I could put that one back in. The constructor that your code snippet shows cannot return however, as it conflicts with this constructor: EnvEntry(Object scope, String jndiName, Object objToBind) The EnvEntry (String jndiName, Object objToBind, boolean override) constructor conflicted with the one above because the xml->java parser selects the constructor above and binds what should be the name as the scope, the object as the name and the override as the value. When I deleted this constructor, I also deleted the 2 arg constructor that called it. I'll look at putting that back in. cheers Jan
Hide
Permalink
Jan Bartel added a comment -

The fix for JETTY-768 took out the 2-arg constructor.

Show
Jan Bartel added a comment - The fix for JETTY-768 took out the 2-arg constructor.
Hide
Permalink
Jan Bartel added a comment -

Fixed for jetty6 and jetty7.

Show
Jan Bartel added a comment - Fixed for jetty6 and jetty7.

People

  • Assignee:
    Jan Bartel
    Reporter:
    Mike T. Miller
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: